Skip to content

Commit 35c19c4

Browse files
.github/workflows/vmui.yml: remove eslint annotation action
Remove the unmaintained third-party `ataylorme/eslint-annotate-action` from the vmui workflow in order to reduce supply-chain risk. Switch `npm run lint` back to human-readable ESLint output, since the JSON report was used only by the removed action. The `make vmui-lint` command still fails CI on lint errors. Printing ESLint errors in the workflow logs should be enough for blocking pull requests with lint errors. See the alternatives considered and why this was removed: VictoriaMetrics/VictoriaMetrics#11259 (comment) Signed-off-by: Rudransh Shrivastava <rudransh@victoriametrics.com>
1 parent 61506b1 commit 35c19c4

2 files changed

Lines changed: 1 addition & 9 deletions

File tree

.github/workflows/vmui.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ jobs:
2424
vmui-checks:
2525
name: VMUI Checks (lint, test, typecheck)
2626
permissions:
27-
checks: write
2827
contents: read
29-
pull-requests: read
3028
runs-on: ubuntu-latest
3129
steps:
3230
- name: Code checkout
@@ -69,12 +67,6 @@ jobs:
6967
run: make vmui-typecheck
7068
continue-on-error: true
7169

72-
- name: Annotate Code Linting Results
73-
uses: ataylorme/eslint-annotate-action@d57a1193d4c59cbfbf3f86c271f42612f9dbd9e9 # 3.0.0
74-
with:
75-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
76-
report-json: app/vmui/packages/vmui/vmui-lint-report.json
77-
7870
- name: Check overall status
7971
run: |
8072
echo "Lint status: ${{ steps.lint.outcome }}"

app/vmui/packages/vmui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"scripts": {
88
"start": "vite",
99
"build": "vite build",
10-
"lint": "eslint --output-file vmui-lint-report.json --format json 'src/**/*.{ts,tsx}'",
10+
"lint": "eslint --format stylish 'src/**/*.{ts,tsx}'",
1111
"lint:fix": "eslint 'src/**/*.{ts,tsx}' --fix",
1212
"preview": "vite preview",
1313
"typecheck": "tsc --noEmit",

0 commit comments

Comments
 (0)