bug: Duplicate kubelet metrics scraped by default with victoria-metrics-k8s-stack helm chart

[jmealo]

Chart name and version
chart: victoria-metrics-k8s-stack
version: .

Describe the bug
/metrics/cadvisor is deprecated. It creates duplicate data and one has to filter on the metrics path to eliminate the duplicates.

https://github.com/VictoriaMetrics/helm-charts/blob/master/charts/victoria-metrics-k8s-stack/values.yaml#L1015

I think this should be removed by default.

[AndrewChubatiuk]

disabled by default, will be available in the next release

[jmealo]

@AndrewChubatiuk We need to make sure the bundled alerts don't have metrics_path="/metrics/cadvisor" in them.

I see it in a couple of places:
https://github.com/search?q=repo%3AVictoriaMetrics%2Fhelm-charts%20%2Fmetrics%2Fcadvisor&type=code

[AndrewChubatiuk]

reverted this change, we're using 3rd party rules and dashboards for k8s components, need to submit a PR there first

[jmealo]

I had a feeling that's what we'd need to do. Glad we caught it early on a Friday. 😂 Thanks for jumping on this so quickly.

[makasim]

Hi @jmealo, just checking in, were you able to submit PRs to the https://github.com/prometheus-operator/kube-prometheus regarding the /metrics/cadvisor references?

[AndrewChubatiuk]

only subset of metrics can be retrieved from /metrics/resource endpoint, there's no other endpoint, which returns all metrics, that are currently exposed by /metrics/cadvisor. added related reference to an issue from a repo, from which rules are cloned