Skip to content

Commit 05e4bfe

Browse files
committed
finalize/vmauth: follow-up for 8bfad99
Remove unneeded conditional vmauth ingress deletion. Ingress should be deleted by Kubernetes garbage-colletor, since it has owner-reference to the parent vmauth.
1 parent 2727ed8 commit 05e4bfe

File tree

1 file changed

+0
-14
lines changed
  • internal/controller/operator/factory/finalize

1 file changed

+0
-14
lines changed

internal/controller/operator/factory/finalize/vmauth.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,6 @@ func OnVMAuthDelete(ctx context.Context, rclient client.Client, cr *vmv1beta1.VM
4343
return err
4444
}
4545
}
46-
if cr.Spec.Ingress != nil {
47-
vmauthIngress := &networkingv1.Ingress{
48-
ObjectMeta: metav1.ObjectMeta{
49-
Name: cr.PrefixedName(),
50-
Namespace: cr.Namespace,
51-
},
52-
}
53-
if err := removeFinalizeObjByName(ctx, rclient, vmauthIngress, cr.PrefixedName(), cr.Namespace); err != nil {
54-
return err
55-
}
56-
if err := SafeDelete(ctx, rclient, vmauthIngress); err != nil {
57-
return err
58-
}
59-
}
6046

6147
// check ingress
6248
if err := removeFinalizeObjByName(ctx, rclient, &networkingv1.Ingress{}, cr.PrefixedName(), cr.Namespace); err != nil {

0 commit comments

Comments
 (0)