Skip to content

Commit 5289f17

Browse files
f41gh7AndrewChubatiuk
authored andcommitted
address review comment
Signed-off-by: f41gh7 <[email protected]>
1 parent 418ec73 commit 5289f17

File tree

1 file changed

+4
-2
lines changed
  • internal/controller/operator/factory/vmalert

1 file changed

+4
-2
lines changed

internal/controller/operator/factory/vmalert/rules.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,13 +227,15 @@ func selectRulesContent(ctx context.Context, rclient client.Client, cr *vmv1beta
227227
vmRules = deduplicateRules(ctx, vmRules)
228228
}
229229
var brokenRulesByNamespace map[string]int
230+
var brokenRulesTotal int
230231
for _, pRule := range vmRules {
231232
if !build.MustSkipRuntimeValidation {
232233
if err := pRule.Validate(); err != nil {
233234
pRule.Status.CurrentSyncError = err.Error()
234235
if brokenRulesByNamespace == nil {
235236
brokenRulesByNamespace = map[string]int{}
236237
}
238+
brokenRulesTotal++
237239
brokenRulesByNamespace[pRule.Namespace]++
238240
continue
239241
}
@@ -244,13 +246,13 @@ func selectRulesContent(ctx context.Context, rclient client.Client, cr *vmv1beta
244246
if brokenRulesByNamespace == nil {
245247
brokenRulesByNamespace = map[string]int{}
246248
}
249+
brokenRulesTotal++
247250
brokenRulesByNamespace[pRule.Namespace]++
248-
249251
continue
250252
}
251253
rules[fmt.Sprintf("%s-%s.yaml", pRule.Namespace, pRule.Name)] = content
252254
}
253-
logger.SelectedObjects(ctx, "VMRules", len(namespacedNames), len(brokenRulesByNamespace), namespacedNames)
255+
logger.SelectedObjects(ctx, "VMRules", len(namespacedNames), brokenRulesTotal, namespacedNames)
254256
for ns, cnt := range brokenRulesByNamespace {
255257
badConfigsTotal.WithLabelValues(ns).Add(float64(cnt))
256258
}

0 commit comments

Comments
 (0)