cluster: fix HPA cleanup for all cluster CRs (#1679)

Author: AndrewChubatiuk

docs/CHANGELOG.md

@@ -16,6 +16,8 @@ aliases:
 * FEATURE: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): support `namespace` parameter in `attach_metadata` section for all scrape configurations. See [#1654](https://github.com/VictoriaMetrics/operator/issues/1654).
 * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent): support logs collection. See [#1501](https://github.com/VictoriaMetrics/operator/issues/1501).
 
+* BUGFIX: [vmoperator](https://docs.victoriametrics.com/operator/): fixed HPA cleanup logic for all cluster resources, before it was constantly recreated. Bug introduced in [this commit](https://github.com/VictoriaMetrics/operator/commit/983d1678c37497a7d03d2f57821219fd4975deec).
+
 ## [v0.66.1](https://github.com/VictoriaMetrics/operator/releases/tag/v0.66.1)
 
 **Release date:** 06 December 2025

internal/controller/operator/factory/vlcluster/vlcluster.go

@@ -100,7 +100,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1.VLClust
 		if newSelect.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newSelect.HPA == nil {
+		if newSelect.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)
@@ -126,7 +126,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1.VLClust
 		if newInsert.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newInsert.HPA == nil {
+		if newInsert.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)

internal/controller/operator/factory/vmcluster/vmcluster.go

@@ -1192,7 +1192,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1beta1.VM
 		if newSelect.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newSelect.HPA == nil {
+		if newSelect.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)
@@ -1218,7 +1218,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1beta1.VM
 		if newInsert.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newInsert.HPA == nil {
+		if newInsert.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)

internal/controller/operator/factory/vtcluster/cluster.go

@@ -100,7 +100,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1.VTClust
 		if newSelect.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newSelect.HPA == nil {
+		if newSelect.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)
@@ -126,7 +126,7 @@ func deleteOrphaned(ctx context.Context, rclient client.Client, cr *vmv1.VTClust
 		if newInsert.PodDisruptionBudget != nil {
 			cc.KeepPDB(commonName)
 		}
-		if newInsert.HPA == nil {
+		if newInsert.HPA != nil {
 			cc.KeepHPA(commonName)
 		}
 		cc.KeepService(commonName)