Skip to content

vlsingle, vmsingle, vtsingle: do not mount emptyDir if data volume is present in spec.volumes #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewChubatiuk wants to merge 2 commits into
base: master
Choose a base branch
from

changed order of volume and mounts for backward compatibility

e6fd498
Select commit
Loading
Failed to load commit list.
Refresh
Sign in for the full log view
Open

vlsingle, vmsingle, vtsingle: do not mount emptyDir if data volume is present in spec.volumes #1489

changed order of volume and mounts for backward compatibility
e6fd498
Select commit
Loading
Failed to load commit list.
GitHub Actions / JUnit Test Report failed Dec 9, 2025 in 0s

131 tests run, 130 passed, 0 skipped, 1 failed.

Annotations

Check failure on line 1 in e2e suite

See this annotation in the file changed.

@github-actions github-actions / JUnit Test Report

e2e suite.[It] test vmalertmanager Controller e2e vmalertmanager should create alertmanager with strict security and vm config reloader [vm, alertmanager] 

Expected
    <string>: pod isn't ready: vmalertmanager-strict-vmreloader-create-0,
     status: &PodStatus{Phase:Running,Conditions:[]PodCondition{PodCondition{Type:PodReadyToStartContainers,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:56 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},PodCondition{Type:Initialized,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:57 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},PodCondition{Type:Ready,Status:False,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:ContainersNotReady,Message:containers with unready status: [config-reloader],ObservedGeneration:0,},PodCondition{Type:ContainersReady,Status:False,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:ContainersNotReady,Message:containers with unready status: [config-reloader],ObservedGeneration:0,},PodCondition{Type:PodScheduled,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},},Message:,Reason:,HostIP:172.18.0.2,PodIP:10.244.0.17,StartTime:2025-12-09 12:32:52 +0000 UTC,ContainerStatuses:[]ContainerStatus{ContainerStatus{Name:alertmanager,State:ContainerState{Waiting:nil,Running:&ContainerStateRunning{StartedAt:2025-12-09 12:33:06 +0000 UTC,},Terminated:nil,},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:true,RestartCount:0,Image:quay.io/prometheus/alertmanager:v0.29.0,ImageID:quay.io/prometheus/alertmanager@sha256:88743b63b3e09ea6e31e140ced5bf45f4a8e82c617c2a963f78841f4995ad1d7,ContainerID:containerd://0b57a257191009d2d5aa1eaabea59cace7fba3c29a1e6c5be20a0514c0ba7b99,Started:*true,AllocatedResources:ResourceList{},Resources:nil,VolumeMounts:[]VolumeMountStatus{VolumeMountStatus{Name:config-volume,MountPath:/etc/alertmanager/config,ReadOnly:true,RecursiveReadOnly:*Disabled,},VolumeMountStatus{Name:vmalertmanager-strict-vmreloader-create-db,MountPath:/alertmanager,ReadOnly:false,RecursiveReadOnly:nil,},VolumeMountStatus{Name:tls-assets,MountPath:/etc/alertmanager/tls_assets,ReadOnly:true,RecursiveReadOnly:*Disabled,},},User:nil,AllocatedResourcesStatus:[]ResourceStatus{},StopSignal:nil,},ContainerStatus{Name:config-reloader,State:ContainerState{Waiting:nil,Running:&ContainerStateRunning{StartedAt:2025-12-09 12:33:06 +0000 UTC,},Terminated:nil,},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:false,RestartCount:0,Image:quay.io/victoriametrics/operator:config-reloader-v0.65.0,ImageID:quay.io/victoriametrics/operator@sha256:d97dfe3ca2ddda2c8d7cc4886372e06a50559dff996acae1a44e1b470fce7f9e,ContainerID:containerd://bc19f67f70769774c4f251e6c89f2dbcf875749aee5bb0e85e256b648dc882c3,Started:*true,AllocatedResources:ResourceList{},Resources:nil,VolumeMounts:[]VolumeMountStatus{VolumeMountStatus{Name:config-volume,MountPath:/etc/alertmanager/config,ReadOnly:false,RecursiveReadOnly:nil,},VolumeMountStatus{Name:tls-assets,MountPath:/etc/alertmanager/tls_assets,ReadOnly:true,RecursiveReadOnly:*Disabled,},VolumeMountStatus{Name:kube-api-access,MountPath:/var/run/secrets/kubernetes.io/serviceaccount,ReadOnly:true,RecursiveReadOnly:*Disabled,},},User:nil,AllocatedResourcesStatus:[]ResourceStatus{},StopSignal:nil,},},QOSClass:BestEffort,InitContainerStatuses:[]ContainerStatus{ContainerStatus{Name:config-init,State:ContainerState{Waiting:nil,Running:nil,Terminated:&ContainerStateTerminated{ExitCode:0,Signal:0,Reason:Completed,Message:,StartedAt:2025-12-09 12:32:56 +0000 UTC,FinishedAt:2025-12-09 12:32:57 +0000 UTC,ContainerID:containerd://95757be39ee5e96b44c5cbdb7bbc01e4fba6937c6571299d91399478a671bdc3,},},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:true,RestartCount:0,Image:quay.io/victoriametrics/operator:config-reloader-v0.65.0,ImageID:quay.io/victoriametrics/operator@sha256:d97dfe3c...

Gomega truncated this representation as it exceeds 'format.MaxLength'.
Consider having the object provide a custom 'GomegaStringer' representation
or adjust the parameters in Gomega's 'format' package.

Learn more here: https://onsi.github.io/gomega/#adjusting-output

to be empty
Raw output 
[FAILED] Expected
    <string>: pod isn't ready: vmalertmanager-strict-vmreloader-create-0,
     status: &PodStatus{Phase:Running,Conditions:[]PodCondition{PodCondition{Type:PodReadyToStartContainers,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:56 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},PodCondition{Type:Initialized,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:57 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},PodCondition{Type:Ready,Status:False,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:ContainersNotReady,Message:containers with unready status: [config-reloader],ObservedGeneration:0,},PodCondition{Type:ContainersReady,Status:False,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:ContainersNotReady,Message:containers with unready status: [config-reloader],ObservedGeneration:0,},PodCondition{Type:PodScheduled,Status:True,LastProbeTime:0001-01-01 00:00:00 +0000 UTC,LastTransitionTime:2025-12-09 12:32:52 +0000 UTC,Reason:,Message:,ObservedGeneration:0,},},Message:,Reason:,HostIP:172.18.0.2,PodIP:10.244.0.17,StartTime:2025-12-09 12:32:52 +0000 UTC,ContainerStatuses:[]ContainerStatus{ContainerStatus{Name:alertmanager,State:ContainerState{Waiting:nil,Running:&ContainerStateRunning{StartedAt:2025-12-09 12:33:06 +0000 UTC,},Terminated:nil,},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:true,RestartCount:0,Image:quay.io/prometheus/alertmanager:v0.29.0,ImageID:quay.io/prometheus/alertmanager@sha256:88743b63b3e09ea6e31e140ced5bf45f4a8e82c617c2a963f78841f4995ad1d7,ContainerID:containerd://0b57a257191009d2d5aa1eaabea59cace7fba3c29a1e6c5be20a0514c0ba7b99,Started:*true,AllocatedResources:ResourceList{},Resources:nil,VolumeMounts:[]VolumeMountStatus{VolumeMountStatus{Name:config-volume,MountPath:/etc/alertmanager/config,ReadOnly:true,RecursiveReadOnly:*Disabled,},VolumeMountStatus{Name:vmalertmanager-strict-vmreloader-create-db,MountPath:/alertmanager,ReadOnly:false,RecursiveReadOnly:nil,},VolumeMountStatus{Name:tls-assets,MountPath:/etc/alertmanager/tls_assets,ReadOnly:true,RecursiveReadOnly:*Disabled,},},User:nil,AllocatedResourcesStatus:[]ResourceStatus{},StopSignal:nil,},ContainerStatus{Name:config-reloader,State:ContainerState{Waiting:nil,Running:&ContainerStateRunning{StartedAt:2025-12-09 12:33:06 +0000 UTC,},Terminated:nil,},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:false,RestartCount:0,Image:quay.io/victoriametrics/operator:config-reloader-v0.65.0,ImageID:quay.io/victoriametrics/operator@sha256:d97dfe3ca2ddda2c8d7cc4886372e06a50559dff996acae1a44e1b470fce7f9e,ContainerID:containerd://bc19f67f70769774c4f251e6c89f2dbcf875749aee5bb0e85e256b648dc882c3,Started:*true,AllocatedResources:ResourceList{},Resources:nil,VolumeMounts:[]VolumeMountStatus{VolumeMountStatus{Name:config-volume,MountPath:/etc/alertmanager/config,ReadOnly:false,RecursiveReadOnly:nil,},VolumeMountStatus{Name:tls-assets,MountPath:/etc/alertmanager/tls_assets,ReadOnly:true,RecursiveReadOnly:*Disabled,},VolumeMountStatus{Name:kube-api-access,MountPath:/var/run/secrets/kubernetes.io/serviceaccount,ReadOnly:true,RecursiveReadOnly:*Disabled,},},User:nil,AllocatedResourcesStatus:[]ResourceStatus{},StopSignal:nil,},},QOSClass:BestEffort,InitContainerStatuses:[]ContainerStatus{ContainerStatus{Name:config-init,State:ContainerState{Waiting:nil,Running:nil,Terminated:&ContainerStateTerminated{ExitCode:0,Signal:0,Reason:Completed,Message:,StartedAt:2025-12-09 12:32:56 +0000 UTC,FinishedAt:2025-12-09 12:32:57 +0000 UTC,ContainerID:containerd://95757be39ee5e96b44c5cbdb7bbc01e4fba6937c6571299d91399478a671bdc3,},},LastTerminationState:ContainerState{Waiting:nil,Running:nil,Terminated:nil,},Ready:true,RestartCount:0,Image:quay.io/victoriametrics/operator:config-reloader-v0.65.0,ImageID:quay.io/victoriametrics/operator@sha256:d97dfe3c...

Gomega truncated this representation as it exceeds 'format.MaxLength'.
Consider having the object provide a custom 'GomegaStringer' representation
or adjust the parameters in Gomega's 'format' package.

Learn more here: https://onsi.github.io/gomega/#adjusting-output

to be empty
In [It] at: /home/runner/work/operator/operator/test/e2e/vmalertmanager_test.go:126 @ 12/09/25 12:33:13.151
View more details on GitHub Actions