Skip to content

Commit 384f92f

Browse files
committed
Moving the call to the PartNodeResolver into the WorkInstructionUpdater when updating work instructions for code clarity.
1 parent 3f1381a commit 384f92f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

MESS/MESS.Services/CRUD/WorkInstructions/WorkInstructionService.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -826,8 +826,6 @@ public async Task<bool> UpdateWorkInstructionAsync(WorkInstructionFormDTO dto)
826826
return false;
827827

828828
await _workInstructionUpdater.ApplyAsync(dto, existing, context);
829-
830-
await _partNodeResolver.ResolvePendingNodesAsync(context, existing.Nodes);
831829

832830
await context.SaveChangesAsync();
833831
await transaction.CommitAsync();

MESS/MESS.Services/CRUD/WorkInstructions/WorkInstructionUpdater.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,21 @@ namespace MESS.Services.CRUD.WorkInstructions;
2424
public class WorkInstructionUpdater : IWorkInstructionUpdater
2525
{
2626
private readonly IProductResolver _productResolver;
27+
private readonly IPartNodeResolver _partNodeResolver;
2728
private readonly IPartDefinitionResolver _partDefinitionResolver;
2829

2930
/// <summary>
3031
/// Initializes a new instance of the <see cref="WorkInstructionUpdater"/> class.
3132
/// </summary>
3233
/// <param name="productResolver">The service used for resolving products from product names.</param>
3334
/// <param name="partDefinitionResolver">The service used for resolving the part definition that a work instruction produces.</param>
34-
public WorkInstructionUpdater(IProductResolver productResolver, IPartDefinitionResolver partDefinitionResolver)
35+
/// <param name="partNodeResolver">The service used for resolving part nodes in a work instruction.</param>
36+
public WorkInstructionUpdater(IProductResolver productResolver, IPartDefinitionResolver partDefinitionResolver,
37+
IPartNodeResolver partNodeResolver)
3538
{
3639
_productResolver = productResolver;
3740
_partDefinitionResolver = partDefinitionResolver;
41+
_partNodeResolver = partNodeResolver;
3842
}
3943

4044
/// <summary>
@@ -88,6 +92,8 @@ public async Task ApplyAsync(
8892
await SyncProductsAsync(dto, entity, context);
8993

9094
SyncNodes(dto.Nodes, entity, context);
95+
96+
await _partNodeResolver.ResolvePendingNodesAsync(context, entity.Nodes);
9197
}
9298

9399
private void ApplyScalars(WorkInstructionFormDTO dto, WorkInstruction entity)

0 commit comments

Comments
 (0)