Collection counter starts at 1?

[julianrubisch]

Is there a specific reason why the collection_counter is 1-, not 0-based?

I had to do some weird shenanigans rendering the code rather unreasonable when aligning it to a standard Ruby array...

[joelhawksley]

@julianrubisch thanks for bringing this up! I just tested a sample Rails partial collection rendering, and it does indeed provide a 0-based index, unlike the ViewComponent counters which are 1-based.

Here is the PR where we discussed this feature at length: #306.

@jonspalmer @franks921 @tclem can you provide context here? My gut says we should look at switching to zero-based.

[tclem]

Oh yeah, I'm surprised by this as well. I think 0-based is the way to go.

[frank-who]

Hi @joelhawksley. This was purely semantics as it physically counts each item. I am happy to open a PR and make it 0-based.

[julianrubisch]

The only case I can think of where 1-based indexing is a thing are database records...

[frank-who]

Upon further reflection it does make more sense sticking to 0-based. I created a PR that reverts it back to the way I had when I first opened the PR #361