Access to global Rails configuration within components

[tangentus]

I decided to open this up as a question instead of an issue because I am unsure if it is expected and wanted behavior, or if it is a bug.

TLDR: Should asset helpers for webpack assets be able to access important/relevant global Rails configuration (i.e. Rails.configuration) variables from within a view-component? The example outlined below is the asset_host configuration which can be used to CDN your assets.

Setup

• A Rails app using webpacker
• Configured the config.action_controller.asset_host variable to host assets on a CDN.
• A view-component that accesses the helper method asset_pack_path to get an image/asset URL
• Controller views that use the same helper method asset_pack_path to get an image/asset URL

Experience

• The ViewComponent will not respect the CDN configured, in fact, the config object that is used is completely empty, and unable to access any Rails configuration details.
• The Controller view works as expected and can access the configuration variable.

Code in question: (same code for both the controller view as well as the component .erb

image_tag(asset_pack_path("media/images/some_image.png")) %>

[mellowfish]

This is due to the isolation of ViewComponent context. However,

<%= image_tag(helpers.asset_pack_path("media/images/some_image.png")) %>

should work correctly.

See this test (and associated component) for confirmation of this functionality: https://github.com/github/view_component/blob/master/test/view_component/view_component_test.rb#L272

[tangentus]

I will give this a go! I had forgotten about the helpers method that was available in components, I have used it for something else in a different application. Thank you! I am going to give this a go, but I am almost certain this is what I need.

[tangentus]

@mellowfish So, testing out this helpers method didn't do the trick. It still is not able to retrieve the value from the configuration.

[tangentus]

@joelhawksley I will definitely give this a go today!

[tangentus]

@joelhawksley It does not look like that solves my issue. I am also trying it with the helpers. access and it isn't working. I have temporarily patched this by just passing in the host attribute on that method to manually override.

[joelhawksley]

@tbroad-ramsey darn. Could you open a PR with a failing test for this issue? I'd like to see us address it.

[tangentus]

@joelhawksley Would love to! Should have time today to do this, if not tomorrow. Thanks!

[tangentus]

@joelhawksley Did ya one better and (I think) fixed it as well in #379

[joelhawksley]

Resolved in https://github.com/github/view_component/releases/tag/v2.11.0 by @tbroad-ramsey.