Does not compile with latest GoTools

[agemuend]

When compiling with latest GoTools from Github I get the following error:

[ 18%] Building CXX object CMakeFiles/LRSpline.dir/src/Profiler.cpp.o
In file included from /home/gemuend/IFEM/LRsplines/src/LRSplineSurface.cpp:1:
/home/gemuend/IFEM/LRsplines/include/LRSpline/LRSplineSurface.h:27:8: error: redefinition of ‘struct Go::BasisDerivsSf3’
   27 | struct BasisDerivsSf3
      |        ^~~~~~~~~~~~~~
In file included from /home/gemuend/IFEM/LRsplines/include/LRSpline/LRSplineSurface.h:7,
                 from /home/gemuend/IFEM/LRsplines/src/LRSplineSurface.cpp:1:
/home/gemuend/IFEM/install/include/GoTools/geometry/SplineSurface.h:153:8: note: previous definition of ‘struct Go::BasisDerivsSf3’
  153 | struct BasisDerivsSf3
      |        ^~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/LRSpline.dir/src/LRSplineSurface.cpp.o] Error 1

Is this expected, should we be using an older version of GoTools? Or is LRSplines now part of GoTools and we dont need to install it separately?

[akva2]

this should be probed by the buildsystem, https://github.com/VikingScientist/LRsplines/blob/master/CMakeLists.txt#L89 did you build in a clean build directory?

that being said, we are generally using an old frozen and patched GoTools, and I have not tried master for a long time for that reason. see https://launchpad.net/~ifem/+archive/ubuntu/ppa/+packages

[agemuend]

this should be probed by the buildsystem, https://github.com/VikingScientist/LRsplines/blob/master/CMakeLists.txt#L89 did you build in a clean build directory?

Yes, I did. I'll trace the cmake output to see why the check didn't work.

that being said, we are generally using an old frozen and patched GoTools, and I have not tried master for a long time for that reason. see https://launchpad.net/~ifem/+archive/ubuntu/ppa/+packages

Oh yes, I've noticed that. I actually opened an issue on GoTools about that.

[agemuend]

Okay, indeed I see it tried:

-- Check size of Go::BasisDerivsSf3 - failed

It seems to me that CMake doesn't use the include paths with check_type_size()? At least it fails because it doesn't find the SplineSurface.h. When I globally set CPLUS_INCLUDE_PATH before it works. Thanks!

[akva2]

that is very likely. typically forget those since stuff is in system paths. patch welcome!

[agemuend]

It seems a bit redundant, but this works:

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -84,6 +84,7 @@ IF(GoTools_FOUND)
   set(LRSpline_DEFINITIONS "${LRSpline_DEFINITIONS} -DHAS_GOTOOLS")

   include(CheckTypeSize)
+  set(CMAKE_REQUIRED_INCLUDES ${GoTools_INCLUDE_DIRS})
   set(CMAKE_EXTRA_INCLUDE_FILES "GoTools/geometry/SplineSurface.h")
   set(CMAKE_REQUIRED_FLAGS -std=c++11)
   check_type_size(Go::BasisDerivsSf3 HAS_BD3 LANGUAGE CXX)

[akva2]

it's not redundant, it is simply how you set includes for probes.

[agemuend]

I thought because its set in INCLUDES before, but if its right, even better. ;)

[akva2]

right, INCLUDES applies to targets being built, but not probes.

[VikingScientist]

@akva2 : Can you confirm that this issue has been solved with #54