Fix cloning did not correctly apply all previous values

Valentin Clavreul · Valentin Clavreul · commit 81914fae3963 · 2020-01-22T17:46:18.000+01:00
diff --git a/Entity/AbstractData.php b/Entity/AbstractData.php
@@ -874,8 +874,7 @@ public function __clone()
         $this->__construct($this->getFamily());
 
         foreach ($newValues as $newValue) {
-            $this->values->add($newValue);
-            $newValue->setData($this);
+            $this->addValue($newValue);
         }
     }
 
diff --git a/Entity/AbstractValue.php b/Entity/AbstractValue.php
@@ -560,9 +560,6 @@ public function __clone()
     {
         $this->id = null;
         $attribute = $this->getAttribute();
-        if ($this->dataValue && $attribute->getType()->isEmbedded()) {
-            $this->dataValue = clone $this->dataValue;
-        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -874,8 +874,7 @@ public function __clone()`
`874`	`874`	`$this->__construct($this->getFamily());`
`875`	`875`
`876`	`876`	`foreach ($newValues as $newValue) {`
`877`		`- $this->values->add($newValue);`
`878`		`- $newValue->setData($this);`
	`877`	`+ $this->addValue($newValue);`
`879`	`878`	`}`
`880`	`879`	`}`
`881`	`880`
Original file line number	Diff line number	Diff line change
`@@ -560,9 +560,6 @@ public function __clone()`
`560`	`560`	`{`
`561`	`561`	`$this->id = null;`
`562`	`562`	`$attribute = $this->getAttribute();`
`563`		`- if ($this->dataValue && $attribute->getType()->isEmbedded()) {`
`564`		`- $this->dataValue = clone $this->dataValue;`
`565`		`- }`
`566`	`563`	`}`
`567`	`564`
`568`	`565`	`/**`