BMV2PTFXfail.cmake

# XFAILS: tests that currently fail. Most of these are temporary.
# ================================================

####################################################################################################
# 1. P4C Toolchain Issues
# These are issues either with the P4 compiler or the behavioral model executing the code.
# These issues needed to be tracked and fixed in P4C.
####################################################################################################

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Assertion"
  # Assertion 'Default switch case should not be reachable' failed,
  # file '../../include/bm/bm_sim/actions.h' line '369'.
  issue1607-bmv2.p4
  bmv2_copy_headers.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Error when adding match entry to target"
  # Non-const entries not yet supported
  init-entries-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "terminate called after throwing an instance"
  # terminate called after throwing an instance of 'std::out_of_range'
  # h.array[h.h.a].index
  # It turns out that h.h.a matters more than the size of the array
  bmv2_hs1.p4
  control-hs-index-test1.p4
  control-hs-index-test2.p4

  # terminate called after throwing an instance of 'boost::wrapexcept<std::range_error>'
  issue2726-bmv2.p4
  runtime-index-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Exception in thread"
  # The error here is unclear. It looks like a segmentation fault.
  extract_for_header_union.p4
  header-stack-ops-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "At index"
  # At index 0: UNKNOWN, 'Error when adding match entry to target'
  # enums are not supported in P4Runtime yet https://github.com/p4lang/behavioral-model/issues/1178
  issue1062-1-bmv2.p4
  v1model-p4runtime-most-types1.p4
  v1model-p4runtime-enumint-types1.p4

  # At index 0: INVALID_ARGUMENT, 'Bytestring provided does not fit within 0 bits'
  # https://github.com/p4lang/PI/issues/585
  issue2283_1-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unexpected error in RPC handling"
  # Unexpected error in RPC handling
  issue3374.p4
  control-hs-index-test6.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Error when importing p4info"
  v1model-digest-containing-ser-enum.p4
  v1model-digest-custom-type.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Error encountered when cleaning up action profile group"
  # bmv2 issue with one-shot indirect table programming
  # Tracked as https://github.com/p4lang/p4c/issues/5547
  action_profile-bmv2.p4
  action_profile_max_group_size_annotation.p4
  action_profile_sum_of_members_annotation.p4
  # This was previously in this file under a different failure. May revert to
  # "terminate called after throwing" when this one is fixed.
  action_selector_shared-bmv2.p4
  issue297-bmv2.p4
)

####################################################################################################
# 2. P4Testgen Issues
# These are failures in P4Testgen that need to be fixed.
####################################################################################################

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Computations are not supported in update_checksum"
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "is trying to match on a tainted key set"
  # unimplemented feature (for select statement)
  invalid-hdr-warnings1.p4
  issue692-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Only registers with bit or int types are currently supported"
  issue907-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unhandled node type in Bmv2V1ModelCmdStepper: ForStatement"
  forloop-bmv2.p4
  issue4739.p4
  loop-3-clause-tricky2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "nested stack"
  # testgen has issues with arrays
  array1.p4
  array2.p4
)

####################################################################################################
# 3. WONTFIX
# These are failures that can not be solved by changing P4Testgen
####################################################################################################

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Assert error"
  # Assert/Assume error: assert/assume(false).
  bmv2_assert.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Assume error"
  # Assert/Assume error: assert/assume(false).
  bmv2_assume.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unsupported type argument for Value Set"
  pvs-nested-struct.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Computations are not supported in update_checksum"
  issue1765-bmv2.p4
  issue1765-1-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "IfStatement"
  # IfStatement: not supported within a deparser on this target.
  issue887.p4
)
p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Checksum16.get is deprecated and not supported."
  # Not supported
  issue841.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unknown or unimplemented extern method: .*[.]increment"
  # user defined externs
  issue1882-1-bmv2.p4
  issue1882-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unknown or unimplemented extern method: .*[.]update"
  issue2664-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unknown extern method count from type jnf_counter"
  # user defined extern
  issue1193-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Unknown or unimplemented extern method: fn_foo"
  # user defined extern
  issue3091.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "BMv2 target only supports headers with fields totaling a multiple of 8 bits"
  issue3225.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "P4Testgen back end only supports a 'V1Switch' main"
  # Pipeline as a parameter of a switch, not a valid v1model program
  issue1304.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Program is not supported by this target"
  issue986-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Program can not be implemented on this target"
  # The error appears because the table calls itself:
  # apply {
  #  simple_table.apply();
  #  simple_table.apply();
  # }
  # if you remove one of the calls, then the test will pass, but at the end there will be an error:
  # Transmitting packet of size 1333 out of port 0
  issue2344.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "error.NoError: unsupported exact key expression"
  issue1062-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "expected type to be a struct"
  issue3394.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "expected a struct"
  hashing-non-tuple-bmv2.p4
  issue584-1-bmv2.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "is not a constant"
  # Using an uninitialized variable as a header stack index in the parser.
  parser-unroll-test10.p4
)

####################################################################################################
# 4. PARAMETERS NEEDED
####################################################################################################
# These tests require additional input parameters to compile properly.

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "uninitialized: next field read"
  # error: parsedHdr.hstack.next uninitialized: next field read
  # next not implemented in p4c/backends/bmv2/common/expression.cpp line 367
  next-def-use.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "headers: the type should be a struct of headers, stacks, or unions"
  parser-unroll-test3.p4
  parser-unroll-test4.p4
  parser-unroll-test5.p4
)

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "The validity bit of .* is tainted"
  control-hs-index-test3.p4
  control-hs-index-test5.p4
)

####################################################################################################
# 5. PTF tests
# These are failures in PTF test that need to be fixed.
####################################################################################################

p4tools_add_xfail_reason(
  "testgen-p4c-bmv2-ptf"
  "Expected packet was not received on device"
)