Skip to content

Commit ad2e67c

Browse files
committed
Remove ARM checks to fix old Java tests
Foojay Disco API supports aarch64 builds of Java 9 and 10 for Linux, and Gradle supports x86_64 builds on macOS
1 parent 0cdf73e commit ad2e67c

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

build.gradle

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ apply plugin: 'signing'
2222
allprojects {
2323
apply plugin: 'com.gradleup.shadow'
2424
apply plugin: 'java'
25-
ext.isArm = System.getProperty('os.arch') == 'aarch64'
2625

2726
group = 'org.vineflower'
2827

@@ -119,17 +118,8 @@ void createJavaTestDataSet(int version, String suffix = "", List<String> compile
119118
}
120119
tasks.getByName("compileTestDataJava${version}${suffix}Java") {
121120
destinationDirectory = file("testData/classes/java${version}${suffix.toLowerCase()}")
122-
if (project.isArm && version > 8 && version < 11) {
123-
// On ARM systems, a more limited set of JVM versions are available
124-
// We'll accept the `--release` flag so development is at least somewhat possible
125-
javaCompiler = javaToolchains.compilerFor {
126-
languageVersion = JavaLanguageVersion.of(11)
127-
}
128-
options.release = version
129-
} else {
130-
javaCompiler = javaToolchains.compilerFor {
131-
languageVersion = JavaLanguageVersion.of(version)
132-
}
121+
javaCompiler = javaToolchains.compilerFor {
122+
languageVersion = JavaLanguageVersion.of(version)
133123
}
134124

135125
options.compilerArgs = compilerArgs
@@ -140,10 +130,9 @@ void createJavaTestDataSet(int version, String suffix = "", List<String> compile
140130
def testJavaRuntimes = [:]
141131

142132
[8, 9, 11, 16, 17, 21, 25].forEach { version ->
143-
def runtimeVersion = isArm && version > 8 && version < 11 ? 11 : version
144133
createJavaTestDataSet(version)
145134
testJavaRuntimes[version] = javaToolchains.launcherFor {
146-
languageVersion = JavaLanguageVersion.of(runtimeVersion)
135+
languageVersion = JavaLanguageVersion.of(version)
147136
}
148137
}
149138
[16, 17, 21].forEach { version -> createJavaTestDataSet(version, "Preview", ["--enable-preview"]) }

plugins/variable-renaming/build.gradle

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,8 @@ void createJavaTestDataSet(int version, String suffix = "", List<String> compile
1818
}
1919
tasks.getByName("compileTestDataJava${version}${suffix}Java") {
2020
destinationDirectory = file("testData/classes/java${version}${suffix.toLowerCase()}")
21-
if (project.isArm && version > 8 && version < 11) {
22-
// On ARM systems, a more limited set of JVM versions are available
23-
// We'll accept the `--release` flag so development is at least somewhat possible
24-
javaCompiler = javaToolchains.compilerFor {
25-
languageVersion = JavaLanguageVersion.of(11)
26-
}
27-
options.release = version
28-
} else {
29-
javaCompiler = javaToolchains.compilerFor {
30-
languageVersion = JavaLanguageVersion.of(version)
31-
}
21+
javaCompiler = javaToolchains.compilerFor {
22+
languageVersion = JavaLanguageVersion.of(version)
3223
}
3324

3425
options.compilerArgs = compilerArgs
@@ -39,10 +30,9 @@ void createJavaTestDataSet(int version, String suffix = "", List<String> compile
3930
def testJavaRuntimes = [:]
4031

4132
[8].forEach { version ->
42-
def runtimeVersion = isArm && version > 8 && version < 11 ? 11 : version
4333
createJavaTestDataSet(version)
4434
testJavaRuntimes[version] = javaToolchains.launcherFor {
45-
languageVersion = JavaLanguageVersion.of(runtimeVersion)
35+
languageVersion = JavaLanguageVersion.of(version)
4636
}
4737
}
4838

0 commit comments

Comments
 (0)