Skip to content

Commit 3b1da80

Browse files
refactor: rename class, clean noqa comments, remove xfail test (#82)
1 parent 21faa58 commit 3b1da80

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

.github/workflows/docs.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,10 @@ jobs:
2525
- uses: astral-sh/setup-uv@v7
2626
with:
2727
enable-cache: true
28-
- name: Install dependencies
29-
run: uv add --no-sync zensical mkdocstrings-python
3028
- name: Generate API reference markdown files
3129
run: python scripts/generate_api_reference.py
3230
- name: Build documentation site
33-
run: uv run --no-sync zensical build --clean
31+
run: uv run --no-install-project --with zensical --with mkdocstrings-python zensical build --clean
3432
- name: Upload artifact
3533
uses: actions/upload-pages-artifact@v4
3634
with:

src/naive_speculate/dependency/maker.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
"""Provide factory functions to conduct creation of various components."""
22

3+
# ruff: noqa: PLC0415
4+
35
from typing import TYPE_CHECKING
46

57
from naive_speculate.config.registry import InferencerType, KVCacheType, LanguageModelType
@@ -16,7 +18,7 @@ def make_lm(model_name: str) -> LanguageModel:
1618
family_name = model_name.split("/")[0].lower()
1719
match LanguageModelType[family_name]:
1820
case LanguageModelType.QWEN3:
19-
import naive_speculate.infer.lm.qwen3 as impl_module # noqa: PLC0415
21+
import naive_speculate.infer.lm.qwen3 as impl_module
2022

2123
lm_class = impl_module.LanguageModelImpl
2224
return lm_class(model_name=model_name)
@@ -25,9 +27,9 @@ def make_lm(model_name: str) -> LanguageModel:
2527
def make_inferencer(language_model: LanguageModel, inferencer_type: InferencerType) -> Inferencer:
2628
match inferencer_type:
2729
case InferencerType.BASIC:
28-
import naive_speculate.infer.inferencer.basic as impl_module # noqa: PLC0415
30+
import naive_speculate.infer.inferencer.basic as impl_module
2931
case InferencerType.CHUNKWISE:
30-
import naive_speculate.infer.inferencer.chunkwise as impl_module # noqa: PLC0415
32+
import naive_speculate.infer.inferencer.chunkwise as impl_module
3133

3234
inferencer_class = impl_module.InferencerImpl
3335
return inferencer_class(language_model=language_model)
@@ -44,9 +46,9 @@ def make_scorer(language_model: LanguageModel) -> Scorer:
4446
def make_kvcache(kvcache_type: KVCacheType) -> KVCache:
4547
match kvcache_type:
4648
case KVCacheType.DYNAMIC:
47-
import naive_speculate.infer.kvcache.dynamic as impl_module # noqa: PLC0415
49+
import naive_speculate.infer.kvcache.dynamic as impl_module
4850
case KVCacheType.DYNAMIC_NO_UPDATE:
49-
import naive_speculate.infer.kvcache.dynamic_no_update as impl_module # noqa: PLC0415
51+
import naive_speculate.infer.kvcache.dynamic_no_update as impl_module
5052

5153
kvcache_class = impl_module.KVCacheImpl
5254
return kvcache_class()

src/naive_speculate/infer/lm/qwen3.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
from naive_speculate.infer import KVCache
1515

16-
__all__ = ["LanguageModelImpl"]
16+
__all__ = ["LanguageModelImpl", "Qwen3LanguageModel"]
1717

1818

19-
class Qwen3Model(LanguageModel):
20-
"""Qwen3Model wraps huggingface Qwen3 models, implementing `LanguageModel`.
19+
class Qwen3LanguageModel(LanguageModel):
20+
"""Qwen3LanguageModel wraps huggingface Qwen3 models, implementing `LanguageModel`.
2121
2222
Attributes:
2323
hf_model (Qwen3ForCausalLM): The underlying huggingface Qwen3 model.
@@ -70,4 +70,4 @@ def forward(self, query_token_ids: torch.Tensor, kv_cache: KVCache) -> torch.Ten
7070
return forward_out.logits
7171

7272

73-
LanguageModelImpl = Qwen3Model
73+
LanguageModelImpl = Qwen3LanguageModel

tests/unit/infer/kvcache/test_dynamic_no_update.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ class TestDynamicNoUpdateCacheContract(KVCacheContractTests):
1717
def dynamic_no_update_cache(self) -> DynamicNoUpdateCache:
1818
return DynamicNoUpdateCache()
1919

20-
@pytest.mark.xfail(reason="DynamicNoUpdateCache does not support updates", strict=True)
2120
def test_dynamic_cache_update_xfail(
2221
self, dynamic_no_update_cache: DynamicNoUpdateCache, kv_states: list[KVState]
2322
) -> None:
24-
super().update_test(dynamic_no_update_cache, kv_states)
23+
with pytest.raises(AssertionError):
24+
super().update_test(dynamic_no_update_cache, kv_states)
2525

2626
def test_dynamic_cache_update(
2727
self, dynamic_no_update_cache: DynamicNoUpdateCache, kv_states: list[KVState]

0 commit comments

Comments
 (0)