fix: correctly handle test failures and display full error details

- Add fromTestExitCode() to treat exit code 3 as TEST_FAILED for test commands
- Add isTestCommand parameter to BazelProcess.waitAndGetResult()
- Pass isTestCommand=true in ExecuteService for test runs
- Extract fullOutput and errorType in FallbackTestXmlParser for Jest tests

Author: harunaOseni

server/bazelrunner/src/main/kotlin/org/jetbrains/bsp/bazel/bazelrunner/BazelProcess.kt

@@ -18,7 +18,11 @@ class BazelProcess internal constructor(
   private val serverPidFuture: CompletableFuture<Long>?,
   private val finishCallback: () -> Unit = {},
 ) {
-  fun waitAndGetResult(cancelChecker: CancelChecker, ensureAllOutputRead: Boolean = false): BazelProcessResult {
+  fun waitAndGetResult(
+    cancelChecker: CancelChecker,
+    ensureAllOutputRead: Boolean = false,
+    isTestCommand: Boolean = false,
+  ): BazelProcessResult {
     return try {
       val stopwatch = Stopwatch.start()
       val outputProcessor: OutputProcessor =
@@ -39,7 +43,8 @@ class BazelProcess internal constructor(
       val exitCode = outputProcessor.waitForExit(cancelChecker, serverPidFuture, logger)
       val duration = stopwatch.stop()
       logCompletion(exitCode, duration)
-      return BazelProcessResult(outputProcessor.stdoutCollector, outputProcessor.stderrCollector, BazelStatus.fromExitCode(exitCode))
+      val bazelStatus = if (isTestCommand) BazelStatus.fromTestExitCode(exitCode) else BazelStatus.fromExitCode(exitCode)
+      return BazelProcessResult(outputProcessor.stdoutCollector, outputProcessor.stderrCollector, bazelStatus)
     } finally {
       finishCallback()
     }

server/commons/src/main/kotlin/org/jetbrains/bsp/bazel/commons/BazelStatus.kt

@@ -6,6 +6,7 @@ import ch.epfl.scala.bsp4j.StatusCode
 private const val SUCCESS_EXIT_CODE = 0
 private const val BUILD_ERROR_EXIT_CODE = 1
 private const val BAD_COMMAND_LINE_ARGUMENTS_EXIT_CODE = 2
+private const val TEST_FAILED_EXIT_CODE = 3
 private const val CANCEL_EXIT_CODE = 8
 private const val OOM_EXIT_CODE = 33
 
@@ -16,6 +17,7 @@ enum class BazelStatus {
   SUCCESS,
   BAD_COMMAND_LINE_ARGUMENTS,
   BUILD_ERROR,
+  TEST_FAILED,
   CANCEL,
   OOM_ERROR,
   FATAL_ERROR, // for other non-categorized errors
@@ -46,5 +48,16 @@ enum class BazelStatus {
         OOM_EXIT_CODE -> OOM_ERROR
         else -> FATAL_ERROR
       }
+
+    fun fromTestExitCode(exitCode: Int): BazelStatus =
+      when (exitCode) {
+        SUCCESS_EXIT_CODE -> SUCCESS
+        BUILD_ERROR_EXIT_CODE -> BUILD_ERROR
+        BAD_COMMAND_LINE_ARGUMENTS_EXIT_CODE -> BAD_COMMAND_LINE_ARGUMENTS
+        TEST_FAILED_EXIT_CODE -> TEST_FAILED
+        CANCEL_EXIT_CODE -> CANCEL
+        OOM_EXIT_CODE -> OOM_ERROR
+        else -> FATAL_ERROR
+      }
   }
 }

server/server/src/main/kotlin/org/jetbrains/bsp/bazel/server/bep/TestXmlParser.kt

@@ -254,6 +254,8 @@ private class FallbackTestXmlParser(private var bspClientTestNotifier: BspClient
   data class IncompleteTestCase(
     @JacksonXmlProperty(isAttribute = true)
     val name: String,
+    @JacksonXmlProperty(isAttribute = true)
+    val classname: String? = null,
     @JacksonXmlProperty(localName = "error")
     val error: TestResultDetail? = null,
     @JacksonXmlProperty(localName = "failure")
@@ -288,7 +290,7 @@ private class FallbackTestXmlParser(private var bspClientTestNotifier: BspClient
 
     bspClientTestNotifier.startTest(suite.name, suiteTaskId)
     suite.testcase.forEach { testCase ->
-      processIncompleteInfoCase(testCase, suiteTaskId.id, suiteStatus)
+      processIncompleteInfoCase(testCase, suiteTaskId.id)
     }
     bspClientTestNotifier.finishTest(
       suite.name,
@@ -300,15 +302,7 @@ private class FallbackTestXmlParser(private var bspClientTestNotifier: BspClient
     )
   }
 
-  /**
-   * Converts a TestCase into a testStart and a testFinish events.
-   * @param testSuiteStatus - using test suite's status as test case status, because the xml one is not correct
-   */
-  private fun processIncompleteInfoCase(
-    testCase: IncompleteTestCase,
-    parentId: String,
-    testSuiteStatus: TestStatus,
-  ) {
+  private fun processIncompleteInfoCase(testCase: IncompleteTestCase, parentId: String) {
     val testCaseTaskId = TaskId(UUID.randomUUID().toString())
     testCaseTaskId.parents = listOf(parentId)
 
@@ -321,7 +315,33 @@ private class FallbackTestXmlParser(private var bspClientTestNotifier: BspClient
         else -> null
       }
 
-    val testCaseData = JUnitStyleTestCaseData(testCase.time, null, outcomeMessage, null, null)
+    // Extract the full error message content.
+    val fullOutput =
+      when {
+        testCase.error != null -> testCase.error.content
+        testCase.failure != null -> testCase.failure.content
+        testCase.skipped != null -> testCase.skipped.content
+        else -> ""
+      }
+
+    // Map the outcome into a TestStatus value.
+    val testStatusOutcome =
+      when {
+        testCase.error != null -> TestStatus.FAILED
+        testCase.failure != null -> TestStatus.FAILED
+        testCase.skipped != null -> TestStatus.SKIPPED
+        else -> TestStatus.PASSED
+      }
+
+    // Extract error type information if provided.
+    val errorType =
+      when {
+        testCase.error != null -> testCase.error.type
+        testCase.failure != null -> testCase.failure.type
+        else -> null
+      }
+
+    val testCaseData = JUnitStyleTestCaseData(testCase.time, testCase.classname, outcomeMessage, fullOutput, errorType)
 
     // In the generated xml, suite name and test case name are the same, but in the Test Console test names have
     // to be unique
@@ -330,7 +350,7 @@ private class FallbackTestXmlParser(private var bspClientTestNotifier: BspClient
     bspClientTestNotifier.finishTest(
       testCaseName,
       testCaseTaskId,
-      testSuiteStatus,
+      testStatusOutcome,
       null,
       JUnitStyleTestCaseData.DATA_KIND,
       testCaseData,

server/server/src/main/kotlin/org/jetbrains/bsp/bazel/server/sync/ExecuteService.kt

@@ -226,7 +226,7 @@ class ExecuteService(
             command,
             originId = params.originId,
             serverPidFuture = bepReader.serverPid,
-          ).waitAndGetResult(cancelChecker, true)
+          ).waitAndGetResult(cancelChecker, ensureAllOutputRead = true, isTestCommand = true)
       }
 
     return TestResult(result.bspStatusCode).apply {