First correction accordance with the recommendations

Author: Виталий

.gitignore

@@ -3,3 +3,6 @@
 dist/
 *.pyc
 hello.py
+.idea/
+__pycache__
+*_cache/

brain_games/engine_game.py

@@ -1,24 +1,21 @@
 import prompt
 
 
-def engine(rule: str, questions: list, right_answer: list):
+def run_game(displays_rules_game, generating_question_and_answer):
+    NUMBER_QUESTIONS = 3
     print('Welcome to the Brain Games!')
     name = prompt.string('May I have your name? ')
     print(f'Hello, {name}!')
-    print(rule)
-    num_questions = len(questions)
-    num_errors = 0
-    while num_questions > 0:
-        print(f"Question: {questions[num_questions - 1]}")
+    displays_rules_game()
+    for _ in range(NUMBER_QUESTIONS):
+        question, right_answer = generating_question_and_answer()
+        print(f"Question: {question}")
         response_user = prompt.string('Your answer: ')
-        if response_user == right_answer[num_questions - 1]:
+        if response_user == right_answer:
             print('Correct!')
-            num_questions -= 1
         else:
             print(f"'{response_user}' is wrong answer ;(. ", end='')
-            print(f"Correct answer was '{right_answer[num_questions - 1]}'.")
+            print(f"Correct answer was '{right_answer}'.")
             print(f"Let's try again, {name}!")
-            num_questions = 0
-            num_errors = 1
-    if num_errors == 0:
-        print(f"Congratulations, {name}!")
+            return
+    print(f"Congratulations, {name}!")

brain_games/games/calc.py

@@ -1,17 +1,22 @@
 from random import choice, randint
 
-rules = "What is the result of the expression?"
-questions = []
-right_answer = []
-for _ in range(3):
-    num1 = randint(1, 25)
-    num2 = randint(1, 25)
+
+def displays_rules_game():
+    print("What is the result of the expression?")
+
+
+def generating_question_and_answer():
+    MIN_GEN_RANGE = 1
+    MAX_GEN_RANGE = 25
+    num1 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    num2 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     operation = choice('+-*')
-    questions.append(f"{str(num1)} {operation} {str(num2)}")
+    question = f"{str(num1)} {operation} {str(num2)}"
     match operation:
         case "+":
-            right_answer.append(str(num1 + num2))
+            answer = str(num1 + num2)
         case "-":
-            right_answer.append(str(num1 - num2))
+            answer = str(num1 - num2)
         case "*":
-            right_answer.append(str(num1 * num2))
+            answer = str(num1 * num2)
+    return ((question, answer))

brain_games/games/even.py

@@ -1,12 +1,17 @@
 from random import randint
 
-rules = 'Answer "yes" if the number is even, otherwise answer "no".'
-questions = []
-right_answer = []
-for _ in range(3):
-    number = randint(1, 100)
-    questions.append(number)
+
+def displays_rules_game():
+    print('Answer "yes" if the number is even, otherwise answer "no".')
+
+
+def generating_question_and_answer():
+    MIN_GEN_RANGE = 1
+    MAX_GEN_RANGE = 100
+    number = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    question = str(number)
     if number % 2 == 0:
-        right_answer.append('yes')
+        answer = 'yes'
     else:
-        right_answer.append('no')
+        answer = 'no'
+    return ((question, answer))

brain_games/games/gcd.py

@@ -1,7 +1,7 @@
 from random import randint
 
 
-def nod(num1, num2):       # нахождение наибольшего общего делителя
+def finding_gcd(num1, num2):       # нахождение наибольшего общего делителя
     while num1 != 0 and num2 != 0:
         if num1 > num2:
             num1 = num1 % num2
@@ -10,11 +10,15 @@ def nod(num1, num2):       # нахождение наибольшего общ
     return (num1 + num2)
 
 
-rules = "Find the greatest common divisor of given numbers."
-questions = []
-right_answer = []
-for _ in range(3):
-    num1 = randint(1, 10)
-    num2 = randint(1, 10)
-    questions.append(f"{num1} {num2}")
-    right_answer.append(str(nod(num1, num2)))
+def displays_rules_game():
+    print("Find the greatest common divisor of given numbers.")
+
+
+def generating_question_and_answer():
+    MIN_GEN_RANGE = 2
+    MAX_GEN_RANGE = 10
+    num1 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    num2 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    question = f"{num1} {num2}"
+    answer = str(finding_gcd(num1, num2))
+    return ((question, answer))

brain_games/games/prime.py

@@ -2,8 +2,8 @@
 
 
 # функция проверяет является ли число простым
-# если число простое -> False 
-# если нет -> True
+# если число простое -> True 
+# если нет -> False
 def is_prime(number):
     if number <= 1: 
         return False
@@ -13,13 +13,17 @@ def is_prime(number):
     return True
 
 
-rules = 'Answer "yes" if given number is prime. Otherwise answer "no".'
-questions = []
-right_answer = []
-for _ in range(3):
-    number = randint(1, 100)
-    questions.append(number)
+def displays_rules_game():
+    print('Answer "yes" if given number is prime. Otherwise answer "no".')
+
+
+def generating_question_and_answer():
+    MIN_GEN_RANGE = 1
+    MAX_GEN_RANGE = 130
+    number = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    question = str(number)
     if is_prime(number):
-        right_answer.append('yes')
+        answer = 'yes'
     else:
-        right_answer.append('no')
+        answer = 'no'
+    return ((question, answer))

brain_games/games/progression.py

@@ -1,23 +1,37 @@
 from random import randint
 
 
-def progress(first, step, empty):    # создает арифметическую прогрессию
-    temp = ''
+# функция создает арифметическую прогрессию
+def generating_a_progression(first: int, step: int, empty: int) -> str:
+    question = ''
     for i in range(1, 11):
         if i == empty:
-            temp += '.. '
+            question += '.. '
         else:
-            temp += str(first + step * (i - 1)) + ' '
-    temp = temp.strip()
-    return (temp)
+            question += str(first + step * (i - 1)) + ' '
+    question = question.strip()
+    return (question)
 
 
-rules = "What number is missing in the progression?"
-questions = []
-right_answer = []
-for _ in range(3):
-    first = randint(2, 50)
-    step = randint(2, 20)
-    empty = randint(1, 10)
-    right_answer.append(str(first + step * (empty - 1)))
-    questions.append(progress(first, step, empty))    
+def displays_rules_game():
+    print("What number is missing in the progression?")
+
+
+def generating_question_and_answer():
+    LEN_PROGRESSION = 10
+    MIN_GEN_RANGE = 1
+    MAX_GEN_RANGE = 50
+    #
+    first_element = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    step = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
+    index_of_missing_element = randint(MIN_GEN_RANGE, LEN_PROGRESSION)
+    #
+    answer = str(first_element + step * (index_of_missing_element - 1))
+    question = ''
+    for i in range(LEN_PROGRESSION):
+        if i + 1 == index_of_missing_element:
+            question += '.. '
+        else:
+            question += str(first_element + step * i) + ' '
+    question = question.strip()
+    return ((question, answer))

brain_games/scripts/brain_calc.py

@@ -1,9 +1,12 @@
-import brain_games.engine_game
-from brain_games.games.calc import questions, right_answer, rules
+from brain_games.engine_game import run_game
+from brain_games.games.calc import (
+    displays_rules_game,
+    generating_question_and_answer,
+)
 
 
 def main():
-    brain_games.engine_game.engine(rules, questions, right_answer)
+    run_game(displays_rules_game, generating_question_and_answer)
 
 
 if __name__ == '__main__':

brain_games/scripts/brain_even.py

@@ -1,9 +1,12 @@
-import brain_games.engine_game
-from brain_games.games.even import questions, right_answer, rules
+from brain_games.engine_game import run_game
+from brain_games.games.even import (
+    displays_rules_game,
+    generating_question_and_answer,
+)
 
 
 def main():
-    brain_games.engine_game.engine(rules, questions, right_answer)
+    run_game(displays_rules_game, generating_question_and_answer)
 
 
 if __name__ == '__main__':

brain_games/scripts/brain_games.py

@@ -1,9 +1,5 @@
 import brain_games.cli
-
-
-def greeting():
-    print('Welcome to the Brain Games!')
-    
+   
 
 def main():
     brain_games.cli.welcome_user()