fix: recover audio engine after route changes - #140
Closed
jatinkrmalik wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closed as superseded. Current main already has the safer lazy audio-engine lifecycle, start-failure reset, and fixed input-device support. This PR now conflicts and would regress that model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix recovery from macOS audio route/input format churn by making the recording start path report failure and rebuilding the AVAudioEngine when the current instance may hold stale hardware format state.
This is aimed at failures like:
which can happen after Bluetooth headset connect/disconnect, default input changes, Zoom/Loom microphone activity, or other AVAudioEngine configuration changes.
Changes
AudioRecording.startRecording(...).AppStateand hotkey state immediately ifAudioEnginefails to start.AVAudioEngineafter:AVAudioEngineConfigurationChangescoped to the current engine and re-register the observer when the engine is recreated.Validation
swift test --filter AppStateRecordingGuardTests/testFailedAudioStartResetsRecordingAndHotkeyStateswift buildswift test— 169 tests passedTest notes
Please try this build with Bluetooth headphones connect/disconnect and during/after Zoom or Loom microphone usage to verify VocaMac no longer needs an app restart after input route changes.