From afc7e3a8bcbd8fec30488b8118c1b6399e14434c Mon Sep 17 00:00:00 2001
From: Kanishk Pachauri <itskanishkp.py@gmail.com>
Date: Sun, 16 Aug 2026 01:17:09 +0530
Subject: [PATCH] fix: remove rectangular overlay glow

---
 .../Services/CursorOverlayManager.swift       | 25 ++++++-------------
 Tests/VocaMacTests/CursorOverlayTests.swift   |  8 +++---
 2 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/Sources/VocaMac/Services/CursorOverlayManager.swift b/Sources/VocaMac/Services/CursorOverlayManager.swift
index 6f662ba..9c4df07 100644
--- a/Sources/VocaMac/Services/CursorOverlayManager.swift
+++ b/Sources/VocaMac/Services/CursorOverlayManager.swift
@@ -12,8 +12,8 @@ import SwiftUI
 
 /// Shared overlay dimensions keep the AppKit panel and SwiftUI content in sync.
 enum OverlayLayout {
-    /// Extra transparent margin so brand-green glow is not clipped by the panel.
-    static let glowBleed: CGFloat = 14
+    /// Transparent room for rounded-edge antialiasing at the native panel boundary.
+    static let edgeInset: CGFloat = 2
 
     static func contentSize(for style: OverlayStyle) -> CGSize {
         switch style {
@@ -30,8 +30,8 @@ enum OverlayLayout {
         let content = contentSize(for: style)
         guard content != .zero else { return .zero }
         return CGSize(
-            width: content.width + glowBleed * 2,
-            height: content.height + glowBleed * 2
+            width: content.width + edgeInset * 2,
+            height: content.height + edgeInset * 2
         )
     }
 }
@@ -507,25 +507,16 @@ struct HandyOverlayView: View {
         .clipShape(RoundedRectangle(cornerRadius: cornerRadius, style: .continuous))
         .overlay {
             RoundedRectangle(cornerRadius: cornerRadius, style: .continuous)
-                .stroke(
+                .strokeBorder(
                     viewModel.phase == .recording
                         ? brandGreen.opacity(isPulsing ? 0.95 : 0.55)
                         : strokeBase,
                     lineWidth: viewModel.phase == .recording ? 1.6 : 1
                 )
         }
-        .shadow(
-            color: accentColor.opacity(viewModel.phase == .recording ? (isPulsing ? 0.75 : 0.4) : 0.28),
-            radius: 11,
-            y: 0
-        )
-        .shadow(
-            color: Color.black.opacity(isDark ? 0.45 : 0.18),
-            radius: 8,
-            y: 3
-        )
-        // Transparent bleed so the glow is not clipped by the NSPanel bounds.
-        .padding(OverlayLayout.glowBleed)
+        // Leave only enough transparent room for rounded-edge antialiasing.
+        // There is deliberately no outer shadow that could reveal panel bounds.
+        .padding(OverlayLayout.edgeInset)
         .frame(width: panelSize.width, height: panelSize.height)
         .opacity(viewModel.isActive && hasEntered ? 1 : 0)
         .offset(y: hasEntered ? 0 : slideInOffset)
diff --git a/Tests/VocaMacTests/CursorOverlayTests.swift b/Tests/VocaMacTests/CursorOverlayTests.swift
index dbcb051..0b6a4ca 100644
--- a/Tests/VocaMacTests/CursorOverlayTests.swift
+++ b/Tests/VocaMacTests/CursorOverlayTests.swift
@@ -41,9 +41,7 @@ final class OverlayLayoutTests: XCTestCase {
 
     func testMinimalOverlayUsesCompactStableDimensions() {
         XCTAssertEqual(OverlayLayout.contentSize(for: .minimal), CGSize(width: 108, height: 44))
-        let size = OverlayLayout.size(for: .minimal)
-        XCTAssertEqual(size.width, 108 + OverlayLayout.glowBleed * 2)
-        XCTAssertEqual(size.height, 44 + OverlayLayout.glowBleed * 2)
+        XCTAssertEqual(OverlayLayout.size(for: .minimal), CGSize(width: 112, height: 48))
     }
 
     func testLiveOverlayIsShorterThanTheOriginalPanel() {
@@ -51,8 +49,8 @@ final class OverlayLayoutTests: XCTestCase {
         let size = OverlayLayout.size(for: .live)
 
         XCTAssertEqual(content, CGSize(width: 240, height: 72))
-        XCTAssertEqual(size.width, 240 + OverlayLayout.glowBleed * 2)
-        XCTAssertLessThan(content.width, 360)
+        XCTAssertEqual(size, CGSize(width: 244, height: 76))
+        XCTAssertLessThan(size.width, 360)
     }
 }