Code of conduct #973
YonatanKra
started this conversation in
General
Replies: 1 comment
-
were u looking for this? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
2. type: feature, bug etc.
3. Scope: predefined scopes only
4. PRs should only contain scope related changes (maybe this belongs elsewhere in the doc?)
5. The design document will be added as a github discussion. Example
6. A design document will be written per new component or big feature
7. The design document will focus on API and user stories
8. Design meetings:
5. Each design document will be shared with the group at least 24 hours before the meeting
6. In the dedicated meeting, we will brainstorm over it (cons/pros of suggested APIs)
9. Communicate new components/features that are likely to change to the users. This will be done in the storybook via a tag.
10. Everything that goes into master is production ready. Production ready means:
7. Has a design document
8. The API is fully tested
9. Tests not broken
11. Preliminary collaboration:
10. Early POC collaboration will be done via the StoryBook generated for a PR/Draft
12. Legacy: Tasks should be added to JIRA to remove existing non-ready packages or make them production ready
13. Hard stop on coverage regression
14. All components should be production ready - e.g. cover the main business use cases in tests
15. Typescript - all code should be written in typescript
16. Linting according to the rules in the repository - link to repo lint rules
17. SCSS for styling - styles will
18. Code readability is a must especially in OSS model that encourages unknown contributions and maintenance:
11. If two reviewers claim non readability - the suggestions should be accepted
19. Use internal tooling where applicable
Beta Was this translation helpful? Give feedback.
All reactions