all exceptions now have suffix (#553)

Author: SecondeJK

README.md

@@ -1025,7 +1025,7 @@ And delete the old secret (any application still using these credentials will st
 ```php
 try {
     $response = $client->account()->deleteSecret(API_KEY, 'd0f40c7e-91f2-4fe0-8bc6-8942587b622c');
-} catch(\Vonage\Client\Exception\Request $e) {
+} catch(\Vonage\Client\Exception\RequestException $e) {
     echo $e->getMessage();
 }
 ```
@@ -1383,7 +1383,7 @@ $vonage_client = new Vonage\Client(new Vonage\Client\Credentials\Basic($api_key,
 
 ### Accessing Response Data
 
-When things go wrong, you'll receive an `Exception`. The Vonage exception classes `Vonage\Client\Exception\Request` and `Vonage\Client\Exception\Server` support an additional `getEntity()` method which you can use in addition to `getCode()` and `getMessage()` to find out more about what went wrong. The entity returned will typically be an object related to the operation, or the response object from the API call.
+When things go wrong, you'll receive an `Exception`. The Vonage exception classes `Vonage\Client\Exception\RequestException` and `Vonage\Client\Exception\ServerException` support an additional `getEntity()` method which you can use in addition to `getCode()` and `getMessage()` to find out more about what went wrong. The entity returned will typically be an object related to the operation, or the response object from the API call.
 
 ### Composer installation fails due to Guzzle Adapter
 

src/Account/Client.php

@@ -8,7 +8,7 @@
 use Vonage\Client\APIClient;
 use Vonage\Client\APIResource;
 use Vonage\Client\Exception as ClientException;
-use Vonage\Client\Exception\Request as ClientRequestException;
+use Vonage\Client\Exception\RequestException as ClientRequestException;
 use Vonage\Entity\Filter\KeyValueFilter;
 
 use function count;
@@ -64,7 +64,7 @@ public function getPrefixPricing(string $prefix): array
      * @throws ClientExceptionInterface
      * @throws ClientRequestException
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      */
     public function getSmsPrice(string $country): SmsPrice
     {
@@ -81,7 +81,7 @@ public function getSmsPrice(string $country): SmsPrice
      * @throws ClientExceptionInterface
      * @throws ClientRequestException
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      */
     public function getVoicePrice(string $country): VoicePrice
     {
@@ -95,7 +95,7 @@ public function getVoicePrice(string $country): VoicePrice
     /**
      * @throws ClientRequestException
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      * @throws ClientExceptionInterface
      *
      * @todo This should return an empty result instead of throwing an Exception on no results
@@ -108,7 +108,7 @@ protected function makePricingRequest($country, $pricingType): array
         $pageData = $results->getPageData();
 
         if (is_null($pageData)) {
-            throw new ClientException\Server('No results found');
+            throw new ClientException\ServerException('No results found');
         }
 
         return $pageData;
@@ -119,7 +119,7 @@ protected function makePricingRequest($country, $pricingType): array
      *
      * @throws ClientExceptionInterface
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      *
      * @todo This needs further investigated to see if '' can even be returned from this endpoint
      */
@@ -128,7 +128,7 @@ public function getBalance(): Balance
         $data = $this->getAPIResource()->get('get-balance', [], ['accept' => 'application/json']);
 
         if (is_null($data)) {
-            throw new ClientException\Server('No results found');
+            throw new ClientException\ServerException('No results found');
         }
 
         return new Balance($data['value'], $data['autoReload']);
@@ -150,7 +150,7 @@ public function topUp(string $trx): void
      *
      * @throws ClientExceptionInterface
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      */
     public function getConfig(): Config
     {
@@ -159,7 +159,7 @@ public function getConfig(): Config
         $body = $api->submit();
 
         if ($body === '') {
-            throw new ClientException\Server('Response was empty');
+            throw new ClientException\ServerException('Response was empty');
         }
 
         $body = json_decode($body, true);
@@ -178,7 +178,7 @@ public function getConfig(): Config
      *
      * @throws ClientExceptionInterface
      * @throws ClientException\Exception
-     * @throws ClientException\Server
+     * @throws ClientException\ServerException
      */
     public function updateConfig(array $options): Config
     {
@@ -199,7 +199,7 @@ public function updateConfig(array $options): Config
         $rawBody = $api->submit($params);
 
         if ($rawBody === '') {
-            throw new ClientException\Server('Response was empty');
+            throw new ClientException\ServerException('Response was empty');
         }
 
         $body = json_decode($rawBody, true);

src/Client/APIExceptionHandler.php

@@ -33,7 +33,7 @@ public function getRfc7807Format(): string
     /**
      * @throws Exception\Exception
      *
-     * @return Exception\Request|Exception\Server
+     * @return Exception\RequestException|Exception\ServerException
      */
     public function __invoke(ResponseInterface $response, RequestInterface $request)
     {
@@ -75,11 +75,11 @@ public function __invoke(ResponseInterface $response, RequestInterface $request)
         }
 
         if ($status >= 400 && $status < 500) {
-            $e = new Exception\Request($errorTitle, $status);
+            $e = new Exception\RequestException($errorTitle, $status);
             @$e->setRequest($request);
             @$e->setResponse($response);
         } elseif ($status >= 500 && $status < 600) {
-            $e = new Exception\Server($errorTitle, $status);
+            $e = new Exception\ServerException($errorTitle, $status);
             @$e->setRequest($request);
             @$e->setResponse($response);
         } else {

src/Client/Exception/Conflict.php …c/Client/Exception/ConflictException.phpsrc/Client/Exception/Conflict.php renamed to src/Client/Exception/ConflictException.php src/Client/Exception/Conflict.php renamed to src/Client/Exception/ConflictException.php

@@ -4,6 +4,6 @@
 
 namespace Vonage\Client\Exception;
 
-class Conflict extends \Exception
+class ConflictException extends \Exception
 {
 }

src/Client/Exception/Transport.php …lient/Exception/CredentialsException.phpsrc/Client/Exception/Transport.php renamed to src/Client/Exception/CredentialsException.php src/Client/Exception/Transport.php renamed to src/Client/Exception/CredentialsException.php

@@ -4,6 +4,6 @@
 
 namespace Vonage\Client\Exception;
 
-class Transport extends Exception
+class CredentialsException extends \Exception
 {
 }

src/Client/Exception/Credentials.php …c/Client/Exception/NotFoundException.phpsrc/Client/Exception/Credentials.php renamed to src/Client/Exception/NotFoundException.php src/Client/Exception/Credentials.php renamed to src/Client/Exception/NotFoundException.php

@@ -4,6 +4,6 @@
 
 namespace Vonage\Client\Exception;
 
-class Credentials extends \Exception
+class NotFoundException extends \Exception
 {
 }

src/Client/Exception/Request.php src/Client/Exception/RequestException.phpsrc/Client/Exception/Request.php renamed to src/Client/Exception/RequestException.php

@@ -7,7 +7,7 @@
 use Vonage\Entity\HasEntityTrait;
 use Vonage\Entity\Psr7Trait;
 
-class Request extends Exception
+class RequestException extends Exception
 {
     use HasEntityTrait;
     use Psr7Trait;

src/Client/Exception/Server.php src/Client/Exception/ServerException.phpsrc/Client/Exception/Server.php renamed to src/Client/Exception/ServerException.php

@@ -7,7 +7,7 @@
 use Vonage\Entity\HasEntityTrait;
 use Vonage\Entity\Psr7Trait;
 
-class Server extends Exception
+class ServerException extends Exception
 {
     use HasEntityTrait;
     use Psr7Trait;

src/Client/Exception/ThrottleException.php

@@ -4,7 +4,7 @@
 
 namespace Vonage\Client\Exception;
 
-class ThrottleException extends Server
+class ThrottleException extends ServerException
 {
     /**
      * @var int

src/Client/Exception/NotFound.php …/Client/Exception/TransportException.phpsrc/Client/Exception/NotFound.php renamed to src/Client/Exception/TransportException.php src/Client/Exception/NotFound.php renamed to src/Client/Exception/TransportException.php

@@ -4,6 +4,6 @@
 
 namespace Vonage\Client\Exception;
 
-class NotFound extends \Exception
+class TransportException extends Exception
 {
 }