Add from validation on request (#477)

Author: SecondeJK

src/Verify2/VerifyObjects/VerificationWorkflow.php

@@ -31,6 +31,10 @@ public function __construct(
         if (! in_array($channel, $this->allowedWorkflows, true)) {
             throw new \InvalidArgumentException($this->channel . ' is not a valid workflow');
         }
+
+        if ($this->isInvalidFromValue($this->from)) {
+            throw new \InvalidArgumentException($this->from . ' is not a valid from value');
+        }
     }
 
     public function getChannel(): string
@@ -112,4 +116,30 @@ public function setCustomKeys(array $customKeys): self
 
         return $this;
     }
+
+    protected function isInvalidFromValue(string $fromValue): bool
+    {
+        if ($fromValue === '') {
+            // This is a null value and doesn't need to be validated
+            return false;
+        }
+
+        if (($this->channel === self::WORKFLOW_EMAIL) && filter_var($fromValue, FILTER_VALIDATE_EMAIL)) {
+            return false;
+        }
+
+        if (is_numeric($fromValue)) {
+            $length = strlen($fromValue);
+
+            return $length < 11 || $length > 15;
+        }
+
+        if (ctype_alnum($fromValue)) {
+            $length = strlen($fromValue);
+
+            return $length < 3 || $length > 11;
+        }
+
+        return true;
+    }
 }

test/Verify2/VerifyObjects/VerificationWorkflowTest.php

@@ -0,0 +1,56 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Verify2\VerifyObjects;
+
+use InvalidArgumentException;
+use Vonage\Verify2\VerifyObjects\VerificationWorkflow;
+use VonageTest\VonageTestCase;
+
+class VerificationWorkflowTest extends VonageTestCase
+{
+    public function testWillTakeValidNumericFromValue(): void
+    {
+        $workflow = new VerificationWorkflow(
+            VerificationWorkflow::WORKFLOW_SMS,
+            'xxx',
+            '44773666552'
+        );
+
+        $this->assertInstanceOf(VerificationWorkflow::class, $workflow);
+    }
+
+    public function testWillTakeValidAlphaFromValue(): void
+    {
+        $workflow = new VerificationWorkflow(
+            VerificationWorkflow::WORKFLOW_SMS,
+            'xxx',
+            'ACMECOMPANY'
+        );
+
+        $this->assertInstanceOf(VerificationWorkflow::class, $workflow);
+    }
+
+    public function testWillThrowErrorOnInvalidNumericFromValue(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+
+        $workflow = new VerificationWorkflow(
+            VerificationWorkflow::WORKFLOW_SMS,
+            'xxx',
+            '3459568445'
+        );
+    }
+
+    public function testWillThrowErrorOnInvalidAlphaFromValue(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+
+        $workflow = new VerificationWorkflow(
+            VerificationWorkflow::WORKFLOW_SMS,
+            'xxx',
+            'MYAWESOMECOMPANYISTOOBIG'
+        );
+    }
+}