Skip to content

Commit 58e55c3

Browse files
authored
DEVX-9003: Add max_bitrate to Video::Archives (#321)
* Add max_bitrate as option to Video::Archives#start method
1 parent 131be52 commit 58e55c3

File tree

5 files changed

+20
-9
lines changed

5 files changed

+20
-9
lines changed

Diff for: CHANGES.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 7.29.0
2+
3+
* Adds `max_bitrate` as an option to the `Video::Archives#start` method. [#321](https://github.com/Vonage/vonage-ruby-sdk/pull/321)
4+
15
# 7.28.0
26

37
* Adds templates and template fragments to the Verify v2 implementation. [#318](https://github.com/Vonage/vonage-ruby-sdk/pull/318)

Diff for: lib/vonage/keys.rb

+4-1
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,19 @@ def camelcase(hash)
2828
'remove_stream',
2929
'screenshare_type',
3030
'session_id',
31+
'output_mode',
3132
'stream_mode',
3233
'archive_mode',
34+
'multi_archive_tag',
3335
'language_code',
3436
'max_duration',
3537
'partial_captions',
3638
'status_callback_url',
3739
'audio_rate',
3840
'phone_number',
3941
'hashed_phone_number',
40-
'max_age'
42+
'max_age',
43+
'max_bitrate'
4144
]
4245
hash.transform_keys do |k|
4346
if exceptions.include?(k.to_s)

Diff for: lib/vonage/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# typed: strong
22

33
module Vonage
4-
VERSION = '7.28.0'
4+
VERSION = '7.29.0'
55
end

Diff for: lib/vonage/video/archives.rb

+7-5
Original file line numberDiff line numberDiff line change
@@ -45,19 +45,21 @@ def info(archive_id:)
4545
#
4646
# @param [required, String] :session_id
4747
#
48-
# @param [optional, String] :hasAudio
48+
# @param [optional, String] :has_audio
4949
#
50-
# @param [optional, String] :hasVideo
50+
# @param [optional, String] :has_video
5151
#
5252
# @param [optional, String] :name
5353
#
54-
# @param [optional, String] :outputMode
54+
# @param [optional, String] :output_mode
5555
#
5656
# @param [optional, String] :resolution
5757
#
58-
# @param [optional, String] :streamMode
58+
# @param [optional, String] :stream_mode
5959
#
60-
# @param [optional, String] :multiArchiveTag
60+
# @param [optional, String] :multi_archive_tag
61+
#
62+
# @param [optional, String] :max_bitrate
6163
#
6264
# @param [optional, Hash] :layout
6365
#

Diff for: test/vonage/video/archives_test.rb

+4-2
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,17 @@ def test_start_method_with_optional_params
4343
request_params = {
4444
sessionId: video_session_id,
4545
resolution: '640x480',
46-
streamMode: 'auto'
46+
streamMode: 'auto',
47+
maxBitrate: 200000
4748
}
4849

4950
stub_request(:post, uri).with(body: request_params).to_return(response)
5051

5152
assert_kind_of Vonage::Response, archives.start(
5253
session_id: video_session_id,
5354
resolution: '640x480',
54-
stream_mode: 'auto'
55+
stream_mode: 'auto',
56+
max_bitrate: 200000
5557
)
5658
end
5759

0 commit comments

Comments
 (0)