Skip to content

Commit 345ab21

Browse files
committed
remove HeadTags from core components
1 parent e1a9759 commit 345ab21

File tree

6 files changed

+102
-98
lines changed

6 files changed

+102
-98
lines changed

docusaurus/docs/vulcan-meteor-legacy/features/head-tags.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
title: Head Tags
33
---
44

5+
/!\ In Vulcan Next and Vulcan NPM,
6+
we don't provide Head Tags anymore,
7+
because modern frameworks already provide their own solution at app-level
8+
59
You'll often need to add tags to your app's `<head>` section. There are three ways to do this: using the [Helmet](https://github.com/nfl/react-helmet) library, using the `<Components.HeadTags/>` component, or using the `Head` object.
610

711
## Helmet

packages/react-ui-lite/components/VulcanComponents/liteVulcanComponents/coreComponents.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FormattedMessage } from "@vulcanjs/react-i18n";
2-
import { Button, Loading, HeadTags, TooltipTrigger, Alert } from "../../core";
2+
import { Button, Loading, TooltipTrigger, Alert } from "../../core";
33

44
import {
55
defaultCoreComponents,
@@ -19,6 +19,5 @@ export const liteCoreComponents: Partial<PossibleCoreComponents> = {
1919
// i18n
2020
FormattedMessage,
2121
// core
22-
HeadTags,
2322
TooltipTrigger,
2423
};

packages/react-ui-lite/components/core/HeadTags.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
/**
2+
* @deprecated HeadTags are not exposed anymore,
3+
* copy paste this logic and adapt to your app if you need HeadTags
4+
*/
15
import React, { PureComponent } from "react";
2-
import PropTypes from "prop-types";
36
// import { Helmet } from 'react-helmet';
47
// import { registerComponent, Utils, getSetting, registerSetting, Head } from 'meteor/vulcan:lib';
58
// import compose from "recompose/compose";
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
export { Button } from "./Button";
22
export { Loading } from "./Loading";
3-
export { HeadTags } from "./HeadTags";
43
export { TooltipTrigger } from "./TooltipTrigger";
54
export { Alert } from "./Alert";

packages/react-ui/components/VulcanComponents/typings.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export interface PossibleCoreComponents {
9797
// TODO: define props more precisely
9898
MutationButton: any; //React.ComponentType<MutationButtonProps>;
9999
LoadingButton: React.ComponentType<any>;
100-
HeadTags: React.ComponentType<any>;
101100
// Previously from Bootstrap and Mui
102101
TooltipTrigger: React.ComponentType<any>;
103102
Dropdown: React.ComponentType<any>;

0 commit comments

Comments
 (0)