Fix

Author: W2Wizard

backend/NXTBackend.API.Core/IDomainService.cs

@@ -3,6 +3,7 @@
 // See README in the root project for more information.
 // ============================================================================
 
+using System.Linq.Expressions;
 using NXTBackend.API.Domain.Common;
 using NXTBackend.API.Models;
 
@@ -19,46 +20,54 @@ namespace NXTBackend.API.Core;
 /// <typeparam name="T">The model type.</typeparam>
 public interface IDomainService<T> where T : BaseEntity
 {
-    /// <summary>
-    /// Find the entity by its ID.
-    /// </summary>
-    /// <param name="id">The ID.</param>
-    /// <returns>The entity found by that ID or null if not found.</returns>
-    public Task<T?> FindByIdAsync(Guid id);
+	/// <summary>
+	/// Configures the query to include related entities.
+	/// </summary>
+	/// <param name="includeExpression">Expression that defines the related entity to include.</param>
+	/// <returns>The service instance for method chaining.</returns>
+	IDomainService<T> Include(Expression<Func<T, object>> includeExpression);
 
-    /// <summary>
-    /// Update the entity.
-    /// </summary>
-    /// <param name="entity">The updated entity.</param>
-    /// <returns>The updated entity.</returns>
-    public Task<T> UpdateAsync(T entity);
+	/// <summary>
+	/// Find the entity by its ID.
+	/// </summary>
+	/// <param name="id">The ID.</param>
+	/// <returns>The entity found by that ID or null if not found.</returns>
+	Task<T?> FindByIdAsync(Guid id);
 
-    /// <summary>
-    ///
-    /// </summary>
-    /// <param name="ids"></param>
-    /// <returns></returns>
-    public Task<bool> AreValid(IEnumerable<Guid> ids);
+	/// <summary>
+	/// Update the entity.
+	/// </summary>
+	/// <param name="entity">The updated entity.</param>
+	/// <returns>The updated entity.</returns>
+	Task<T> UpdateAsync(T entity);
 
+	/// <summary>
+	/// Validates if all provided IDs exist in the database.
+	/// </summary>
+	/// <param name="ids">Collection of IDs to validate.</param>
+	/// <returns>True if all IDs are valid, false otherwise.</returns>
+	Task<bool> AreValid(IEnumerable<Guid> ids);
 
-    /// <summary>
-    /// Delete the entity.
-    /// </summary>
-    /// <param name="entity">The entity to delete</param>
-    /// <returns>The deleted entity.</returns>
-    public Task<T> DeleteAsync(T entity);
+	/// <summary>
+	/// Delete the entity.
+	/// </summary>
+	/// <param name="entity">The entity to delete</param>
+	/// <returns>The deleted entity.</returns>
+	Task<T> DeleteAsync(T entity);
 
-    /// <summary>
-    /// Create a new entity.
-    /// </summary>
-    /// <param name="entity">The newly created entity.</param>
-    /// <returns>The newly created entity.</returns>
-    public Task<T> CreateAsync(T entity);
+	/// <summary>
+	/// Create a new entity.
+	/// </summary>
+	/// <param name="entity">The newly created entity.</param>
+	/// <returns>The newly created entity.</returns>
+	Task<T> CreateAsync(T entity);
 
-    /// <summary>
-    /// Get all entities.
-    /// </summary>
-    /// <param name="pagination">Specific pagination parameters (as to avoid large queries)</param>
-    /// <returns>A paginated list of entities.</returns>
-    public Task<PaginatedList<T>> GetAllAsync(PaginationParams pagination, SortingParams sorting, FilterDictionary? filter = null);
-}
+	/// <summary>
+	/// Get all entities.
+	/// </summary>
+	/// <param name="pagination">Specific pagination parameters (as to avoid large queries)</param>
+	/// <param name="sorting">Parameters for sorting the results</param>
+	/// <param name="filter">Optional filters to apply to the query</param>
+	/// <returns>A paginated list of entities.</returns>
+	Task<PaginatedList<T>> GetAllAsync(PaginationParams pagination, SortingParams sorting, FilterDictionary? filter = null);
+}

backend/NXTBackend.API.Core/Notifications/Notification.cs

@@ -5,8 +5,13 @@ namespace NXTBackend.API.Core.Notifications;
 /// <summary>
 /// Represents an abstract base class for notifications that can be sent through various channels.
 /// </summary>
-public abstract class Notification()
+public abstract class Notification
 {
+    /// <summary>
+    /// The ID of the user who should receive this notification
+    /// </summary>
+    public Guid NotifiableId { get; set; }
+
     /// <summary>
     /// Gets the view name for this notification.
     /// Can be overridden by implementing classes.
@@ -24,7 +29,7 @@ public abstract class Notification()
     public virtual string ToText() => string.Empty;
 
     /// <summary>
-    /// Stores this notification in the database using the provided service.
+    /// Stores this notification in the database.
     /// Must be implemented by derived classes.
     /// </summary>
     public abstract Domain.Entities.Notification ToDatabase();
@@ -33,28 +38,18 @@ public abstract class Notification()
     /// Determines whether this notification should be sent.
     /// </summary>
     public virtual bool ShouldSend() => true;
+	
+	/// <summary>
+    /// Determines whether this notification should be ignored / discarded.
+    /// </summary>
+    public virtual bool ShouldBeDiscarded() => false;
 
     /// <summary>
-    /// Retrieves the View (HTML) of this notification
-    /// </summary>
-    /// <param name="name"></param>
-    /// <returns></returns>
-    public string GetTemplate()
-    {
-        // string cacheKey = $"template_{View}";
-        // var cachedTemplate = _cache.GetString(cacheKey);
-        // if (!string.IsNullOrEmpty(cachedTemplate))
-        //     return cachedTemplate;
-
-        // Cache miss - read from file
-        string templatePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "templates", $"{View}.html");
-        string template = File.ReadAllText(templatePath);
-        // var cacheOptions = new DistributedCacheEntryOptions
-        // {
-        //     AbsoluteExpirationRelativeToNow = TimeSpan.FromHours(24)
-        // };
-
-        // _cache.SetString(cacheKey, template, cacheOptions);
-        return template;
-    }
-}
+	/// Retrieves the HTML template for this notification
+	/// </summary>
+	public string GetTemplate()
+	{
+		string templatePath = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "templates", $"{View}.html");
+		return File.ReadAllText(templatePath);
+	}
+}

backend/NXTBackend.API.Core/Notifications/Welcome/Welcome.cs

@@ -10,33 +10,43 @@
 
 namespace NXTBackend.API.Core.Notifications.Welcome;
 
-public class Welcome(User user) : Notification
+public class Welcome : Notification
 {
     public override string View => nameof(Welcome);
+	
+	private readonly User user;
 
-    public override MailMessage ToMail()
-    {
-        var mail = new MailMessage();
+	public Welcome(User to)
+	{
+		user = to;
+	}
 
-        mail.To.Add(user.Details?.Email ?? throw new ServiceException("No Email!"));
-        mail.Subject = "Welcome to our platform!";
+	public override MailMessage ToMail()
+	{
+		var mail = new MailMessage();
 
-        // Render the view to HTML
-        // TODO: Instead I may want to use Razor, but I don't wanna spend 6 years implementing that now
-        mail.Body = GetTemplate()
-            .Replace("{{login}}", user.Login);
-        mail.IsBodyHtml = true;
+		mail.To.Add(user.Details?.Email ?? throw new ServiceException("No Email!"));
+		mail.Subject = "Welcome to our platform!";
 
-        return mail;
-    }
+		// Render the view to HTML
+		// TODO: Instead I may want to use Razor, but I don't wanna spend 6 years implementing that now
+		mail.Body = GetTemplate()
+			.Replace("{{login}}", user.Login);
+		mail.IsBodyHtml = true;
+
+		return mail;
+	}
 
     public override bool ShouldSend()
     {
-        return user.Details?.Email is not null;
+        return true;
     }
 
     public override Domain.Entities.Notification ToDatabase()
     {
-        throw new NotImplementedException();
+        return new Domain.Entities.Notification
+		{
+			Type = nameof(Welcome),
+		};
     }
 }