-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Looking at this PR I can't help but notice there is some common, yet complicated, logic in the workflows regarding entitlement checks. It might make sense to adopt the following process to ease maintenance of this logic.
- Use a
Makefile(or similar) to cause the various.ymlfiles to be assembled such that the duplicate logic is templated from one source file into several.ymlfiles. For example, I observe the logic inDeploy VM using image for evaluation usage is in at least two.yml` files. - Adopt the policy that when making changes to the workflows, the human makes the changes in the file(s) that serve as input to
makeand then runsmakebefore committing the work to git. - Put sufficient warning is the
.ymlfiles that are generated bymakeadvising future humans to not edit the files directly, but rather to edit whatever source files go in tomake.
Of course, you don't have to usemake. Any templating system would work. Perhaps even shell scripts.
Metadata
Metadata
Assignees
Labels
No labels