Thanks for being interested in contributions!
We have some quirks about @wfcd/items
... especially pull requests.
Make sure you've run
npm run lint
npm run build
npm test
before submitting a pull request.
We have a few rules about pull requests:
- Don't use merge commits.
- Always rebase your branch on top of the latest
master
branch.
alias rebase='git fetch -ap && git rebase $(git symbolic-ref refs/remotes/origin/HEAD --short)'
is one of my oft-used git aliases that helps with this.
If you find a bug, please file an issue. If you have a feature request, please file an issue.
In either case, you're welcome to open a pull request with or without an issue, it would just be helpful to have the issue in case your PR gets abandoned or isn't the way we want to implement said fix/feature.
We use Prettier plugged into eslint for code formatting. Please make sure to run npm run lint
before submitting a pull request.
The warframe-items
repository is licensed under the MIT License. By contributing to this repository, you agree that your contributions will be licensed under the same license.