LineSegmentDetector needs to be removed for license

[sciencewhiz]

Per https://www.chiefdelphi.com/t/cpp-multicameraserver-wont-build/375965/7, GRIP generates code that uses LineSegmentDetector. Per opencv/opencv_contrib#2016, LineSegmentDetector used Affero GPL v3 code and was removed. GRIP needs to remove the calls to LineSegmentDetector or relicense to a compatible license.

[virtuald]

If GRIP generates the code but doesn't use it, doesn't that mean the end user's code is AGPLv3, not GRIP?

... but still, removing it would be a good idea.

[sciencewhiz]

It's also used in GRIP to show the results.

GRIP/core/src/main/java/edu/wpi/grip/core/operations/composite/FindLinesOperation.java

Line 72 in 34afc3d

lsd.detect(input.getCpu(), lines);

[JLLeitschuh]

If it's incompatible with BSD, we need to remove our usage too.
CC: @SamCarlberg @AustinShalit

[JLLeitschuh]

More information here:
opencv/opencv_contrib#2524

[ThadHouse]

opencv/opencv_contrib#2016

Based on the latest post, it seems like the author realized the license issue was a mistake, and relicensed the code. So anything shipping with 3.x should be safe.

[GrantPerkins]

#976 migrates to FastLineDetector from LineSegmentDetector