Merge branch 'misuse_1' into cleaning_2: Resolve standalone.rs conflicts

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: Wandalen

module/core/test_tools/src/behavioral_equivalence.rs

@@ -152,7 +152,7 @@ mod private {
       #[cfg(feature = "standalone_build")]
       {
         // Placeholder for standalone mode - macros may not be fully available
-        return Ok(());
+        Ok(())
       }
 
       // COMMENTED OUT: collection_tools dependency disabled to break circular dependencies

module/core/test_tools/src/lib.rs

@@ -411,6 +411,10 @@ pub use test::process;
 ///
 /// ## Historical Context  
 /// This resolves the vec! ambiguity issue while preserving Task 002's macro accessibility.
+#[ cfg( feature = "enabled" ) ]
+#[ allow( unused_imports ) ]
+pub use ::{};
+
 // COMMENTED OUT: error_tools dependency disabled to break circular dependencies
 // #[ cfg( feature = "enabled" ) ]
 // #[cfg(not(all(feature = "standalone_build", not(feature = "normal_build"))))]
@@ -423,10 +427,6 @@ pub use test::process;
 // #[cfg(all(feature = "standalone_build", not(feature = "normal_build")))]
 // pub use implsindex as impls_index;
 
-#[ cfg( feature = "enabled" ) ]
-#[ allow( unused_imports ) ]
-pub use ::{};
-
 /// Verifies that the API stability facade is functioning correctly.
 /// This function can be used to check that all stability mechanisms are operational.
 #[ cfg( feature = "enabled" ) ]

module/core/test_tools/src/standalone.rs

@@ -63,11 +63,19 @@ pub mod error_tools {
     /// The error type for this implementation
     type Error;
     /// Add context to an error using a closure
+    /// 
+    /// # Errors
+    /// 
+    /// Returns an error if the original operation failed, wrapped with contextual information.
     fn err_with<F>(self, f: F) -> Result<T, (String, Self::Error)> 
     where 
       Self: Sized, 
       F: FnOnce() -> String;
     /// Add context to an error using a static string
+    /// 
+    /// # Errors
+    /// 
+    /// Returns an error if the original operation failed, wrapped with the provided report message.
     fn err_with_report(self, report: &str) -> Result<T, (String, Self::Error)> where Self: Sized;
   }
 
@@ -125,18 +133,43 @@ pub mod error_tools {
 
 /// Collection tools for standalone mode
 pub mod collection_tools {
-  use std::hash::Hash;
+  use core::hash::Hash;
   use std::collections::hash_map::RandomState;
 
   /// A hash map implementation using hashbrown for standalone mode
   #[derive(Debug, Clone)]
   pub struct HashMap<K, V>(hashbrown::HashMap<K, V, RandomState>);
 
+  impl<'a, K, V> IntoIterator for &'a HashMap<K, V>
+  where
+    K: Hash + Eq,
+  {
+    type Item = (&'a K, &'a V);
+    type IntoIter = hashbrown::hash_map::Iter<'a, K, V>;
+    
+    fn into_iter(self) -> Self::IntoIter {
+      self.iter()
+    }
+  }
+  
+  impl<'a, K, V> IntoIterator for &'a mut HashMap<K, V>
+  where
+    K: Hash + Eq,
+  {
+    type Item = (&'a K, &'a mut V);
+    type IntoIter = hashbrown::hash_map::IterMut<'a, K, V>;
+    
+    fn into_iter(self) -> Self::IntoIter {
+      self.iter_mut()
+    }
+  }
+
   impl<K, V> HashMap<K, V> 
   where 
     K: Hash + Eq,
   {
     /// Create a new empty `HashMap`
+    #[must_use]
     pub fn new() -> Self {
       Self(hashbrown::HashMap::with_hasher(RandomState::new()))
     }
@@ -149,21 +182,28 @@ pub mod collection_tools {
     /// Get a reference to the value for a given key
     pub fn get<Q>(&self, k: &Q) -> Option<&V> 
     where 
-      K: std::borrow::Borrow<Q>,
+      K: core::borrow::Borrow<Q>,
       Q: Hash + Eq + ?Sized,
     {
       self.0.get(k)
     }
 
     /// Get the number of elements in the `HashMap`
+    #[must_use]
     pub fn len(&self) -> usize {
       self.0.len()
     }
 
+    /// Returns true if the `HashMap` is empty
+    #[must_use]
+    pub fn is_empty(&self) -> bool {
+      self.0.is_empty()
+    }
+    
     /// Get a mutable reference to the value for a given key
     pub fn get_mut<Q>(&mut self, k: &Q) -> Option<&mut V> 
     where 
-      K: std::borrow::Borrow<Q>,
+      K: core::borrow::Borrow<Q>,
       Q: Hash + Eq + ?Sized,
     {
       self.0.get_mut(k)
@@ -172,18 +212,19 @@ pub mod collection_tools {
     /// Remove a key-value pair from the `HashMap`
     pub fn remove<Q>(&mut self, k: &Q) -> Option<V> 
     where 
-      K: std::borrow::Borrow<Q>,
+      K: core::borrow::Borrow<Q>,
       Q: Hash + Eq + ?Sized,
     {
       self.0.remove(k)
     }
 
     /// Clear all key-value pairs from the `HashMap`
     pub fn clear(&mut self) {
-      self.0.clear()
+      self.0.clear();
     }
 
     /// Returns an iterator over all key-value pairs (immutable references)
+    #[must_use]
     pub fn iter(&self) -> hashbrown::hash_map::Iter<'_, K, V> {
       self.0.iter()
     }
@@ -277,13 +318,28 @@ pub mod collection_tools {
 
   impl<T: core::hash::Hash + Eq> Eq for HashSet<T> {}
 
+  impl<'a, T> IntoIterator for &'a HashSet<T>
+  where
+    T: Hash + Eq,
+  {
+    type Item = &'a T;
+    type IntoIter = hashbrown::hash_set::Iter<'a, T>;
+    
+    fn into_iter(self) -> Self::IntoIter {
+      self.iter()
+    }
+  }
+  
   impl<T> HashSet<T> {
     /// Create a new empty `HashSet`
+    #[must_use]
     pub fn new() -> Self {
       Self(hashbrown::HashSet::with_hasher(RandomState::new()))
     }
 
     /// Returns an iterator over the set
+    #[must_use]
+    #[allow(clippy::iter_without_into_iter)]
     pub fn iter(&self) -> hashbrown::hash_set::Iter<'_, T> {
       self.0.iter()
     }
@@ -297,11 +353,13 @@ pub mod collection_tools {
     }
 
     /// Returns the number of elements in the set
+    #[must_use]
     pub fn len(&self) -> usize {
       self.0.len()
     }
 
     /// Returns true if the set is empty
+    #[must_use]
     pub fn is_empty(&self) -> bool {
       self.0.is_empty()
     }
@@ -628,7 +686,6 @@ pub mod collection_tools {
 }
 // Collection tools re-exported at crate level
 #[allow(unused_imports)]
-
 /// Memory tools for standalone mode
 pub mod mem_tools {
   use core::ptr;
@@ -655,8 +712,8 @@ pub mod mem_tools {
     }
 
     // Check if they're the exact same memory location
-    let ptr1 = std::ptr::from_ref(src1).cast::<()>();
-    let ptr2 = std::ptr::from_ref(src2).cast::<()>();
+    let ptr1 = core::ptr::from_ref(src1).cast::<()>();
+    let ptr2 = core::ptr::from_ref(src2).cast::<()>();
     ptr1 == ptr2
   }
 
@@ -686,7 +743,6 @@ pub mod mem_tools {
 }
 // Memory tools re-exported at crate level
 #[allow(unused_imports)]
-
 /// Typing tools for standalone mode
 pub mod typing_tools {
   // Minimal typing utilities for standalone mode
@@ -1247,7 +1303,7 @@ macro_rules! is_slice {
 #[macro_export]
 macro_rules! debug_assert_id_macro {
   ($left:expr, $right:expr) => {
-    crate::debug_assert_id($left, $right);
+    $crate::debug_assert_id($left, $right);
   };
 }
 

module/move/benchkit/examples/cargo_bench_integration.rs

@@ -275,7 +275,7 @@ my_rust_project/
     println!(r#"
 [package]
 name = "my_rust_project"
-version = "0.1.0"
+version = "0.8.0"
 
 # Standard Rust benchmark configuration
 [[bench]]
@@ -287,7 +287,7 @@ name = "algorithm_comparison"
 harness = false
 
 [dev-dependencies]
-benchkit = {{ version = "0.1", features = ["cargo_bench", "regression_analysis"] }}
+benchkit = {{ version = "0.8.0", features = ["cargo_bench", "regression_analysis"] }}
 
 [features]
 # Optional: allow disabling benchmarks in some environments

module/move/benchkit/readme.md

@@ -7,7 +7,7 @@
 
 `benchkit` is a lightweight toolkit for performance analysis, born from the hard-learned lessons of optimizing high-performance libraries. It rejects rigid, all-or-nothing frameworks in favor of flexible, composable tools that integrate seamlessly into your existing workflow.
 
-> 🎯 **NEW TO benchkit?** Start with [`recommendations.md`](recommendations.md) - Essential guidelines from real-world performance optimization experience.
+> 🎯 **NEW TO benchkit?** Start with [`usage.md`](usage.md) - Mandatory standards and requirements from production systems.
 
 ## The Benchmarking Dilemma
 
@@ -18,7 +18,7 @@ In Rust, developers often face a frustrating choice:
 
 `benchkit` offers a third way.
 
-> **📋 Important**: For production use and development contributions, see [`recommendations.md`](recommendations.md) - a comprehensive guide with proven patterns, requirements, and best practices from real-world benchmarking experience.
+> **📋 Important**: For production use and development contributions, see [`usage.md`](usage.md) - mandatory standards with proven patterns, requirements, and compliance standards from production systems.
 
 ## A Toolkit, Not a Framework
 
@@ -33,14 +33,14 @@ This is the core philosophy of `benchkit`. It doesn't impose a workflow; it prov
 
 ## 🚀 Quick Start: Compare, Analyze, and Document
 
-**📖 First time?** Review [`recommendations.md`](recommendations.md) for comprehensive best practices and development guidelines.
+**📖 First time?** Review [`usage.md`](usage.md) for mandatory compliance standards and development requirements.
 
 This example demonstrates the core `benchkit` workflow: comparing two algorithms and automatically updating a performance section in your `readme.md`.
 
 **1. Add to `dev-dependencies` in `Cargo.toml`:**
 ```toml
 [dev-dependencies]
-benchkit = { version = "0.1", features = [ "full" ] }
+benchkit = { version = "0.8.0", features = [ "full" ] }
 ```
 
 **2. Create a benchmark in your `benches` directory:**
@@ -910,7 +910,7 @@ Add to your `Cargo.toml`:
 benchmark = ["benchkit"]
 
 [dev-dependencies]
-benchkit = { version = "0.1", features = ["full"], optional = true }
+benchkit = { version = "0.8.0", features = ["full"], optional = true }
 ```
 
 Run benchmarks selectively:
@@ -1053,12 +1053,12 @@ Add `benchkit` to your `[dev-dependencies]` in `Cargo.toml`.
 benchkit = "0.1"
 
 # Or enable all features for the full toolkit
-benchkit = { version = "0.1", features = [ "full" ] }
+benchkit = { version = "0.8.0", features = [ "full" ] }
 ```
 
 ## 📋 Development Guidelines & Best Practices
 
-**⚠️ IMPORTANT**: Before using benchkit in production or contributing to development, **strongly review** the comprehensive [`recommendations.md`](recommendations.md) file. This document contains essential requirements, best practices, and lessons learned from real-world performance analysis work.
+**⚠️ IMPORTANT**: Before using benchkit in production or contributing to development, **strongly review** the comprehensive [`usage.md`](usage.md) file. This document contains essential requirements, best practices, and lessons learned from real-world performance analysis work.
 
 The recommendations cover:
 - ✅ **Core philosophy** and toolkit vs framework principles
@@ -1067,18 +1067,18 @@ The recommendations cover:
 - ✅ **Documentation integration** requirements for automated reporting
 - ✅ **Statistical analysis** requirements for reliable measurements
 
-**📖 Read [`recommendations.md`](recommendations.md) first** - it will save you time and ensure you're following proven patterns.
+**📖 Read [`usage.md`](usage.md) first** - it will save you time and ensure you're following proven patterns.
 
 ## Contributing
 
 Contributions are welcome! `benchkit` aims to be a community-driven toolkit that solves real-world benchmarking problems. 
 
 **Before contributing:**
-1. **📖 Read [`recommendations.md`](recommendations.md)** - Contains all development requirements and design principles
+1. **📖 Read [`usage.md`](usage.md)** - Contains all development requirements and design principles
 2. Review open tasks in the [`task/`](task/) directory  
 3. Check our contribution guidelines
 
-All contributions must align with the principles and requirements outlined in [`recommendations.md`](recommendations.md).
+All contributions must align with the principles and requirements outlined in [`usage.md`](usage.md).
 
 ## License
 

module/move/benchkit/roadmap.md

@@ -315,6 +315,6 @@ fn compare_algorithms() {
 ## References
 
 - **spec.md** - Complete functional requirements and technical specifications
-- **recommendations.md** - Lessons learned from unilang/strs_tools benchmarking
+- **usage.md** - Lessons learned from unilang/strs_tools benchmarking
 - **Design Rulebook** - Architectural principles and development procedures
 - **Codestyle Rulebook** - Code formatting and structural patterns

module/move/benchkit/spec.md

@@ -614,7 +614,7 @@ fn research_grade_performance_analysis()
 
 ### 12. Lessons Learned Reference
 
-**CRITICAL**: All development decisions for benchkit are based on real-world experience from unilang and strs_tools benchmarking work. The complete set of requirements, anti-patterns, and lessons learned is documented in [`recommendations.md`](recommendations.md).
+**CRITICAL**: All development decisions for benchkit are based on real-world experience from unilang and strs_tools benchmarking work. The complete set of requirements, anti-patterns, and mandatory standards is documented in [`usage.md`](usage.md).
 
 **Key lessons that shaped benchkit design:**
 
@@ -650,7 +650,7 @@ fn research_grade_performance_analysis()
 - **Solution**: Exact matching with `line.trim() == section_marker.trim()` + API validation
 - **Prevention**: Safe API with conflict detection, comprehensive regression tests, backwards compatibility
 
-**For complete requirements and anti-patterns, see [`recommendations.md`](recommendations.md).**
+**For complete requirements and mandatory standards, see [`usage.md`](usage.md).**
 
 ### 13. Cargo Bench Integration Requirements ⭐ **CRITICAL**
 
@@ -673,7 +673,7 @@ name = "performance_suite"
 harness = false  # Use benchkit as the harness
 
 [dev-dependencies]
-benchkit = { version = "0.1", features = ["cargo_bench"] }
+benchkit = { version = "0.8.0", features = ["cargo_bench"] }
 ```
 
 ```rust
@@ -774,6 +774,6 @@ Based on real-world usage patterns and critical path analysis from unilang/strs_
 
 ### Reference Documents
 
-- **[`recommendations.md`](recommendations.md)** - Complete requirements from real-world experience
+- **[`usage.md`](usage.md)** - Mandatory standards and compliance requirements from production systems
 - **[`readme.md`](readme.md)** - Usage-focused documentation with examples  
 - **[`examples/`](examples/)** - Comprehensive usage demonstrations

module/move/benchkit/src/templates.rs

@@ -819,7 +819,7 @@ impl PerformanceReport
     {
       // Fallback to placeholder when no historical data available
       output.push_str( "**Regression Analysis**: Not yet implemented. Historical baseline data required.\n\n" );
-      output.push_str( "**📖 Setup Guide**: See [`recommendations.md`](recommendations.md) for comprehensive guidelines on:\n" );
+      output.push_str( "**📖 Setup Guide**: See [`usage.md`](usage.md) for mandatory standards and requirements on:\n" );
       output.push_str( "- Historical data collection and baseline management\n" );
       output.push_str( "- Statistical analysis requirements and validation criteria\n" );
       output.push_str( "- Integration with CI/CD pipelines for automated regression detection\n" );