style: Apply consistent Rust idioms and lint fixes

Wandalen · Wandalen · commit eeae82c3041c · 2025-09-06T19:17:04.000Z
- Replace Default::default() with explicit struct constructors
- Add reference parameters to prevent unnecessary moves
- Update ignore attributes with descriptive reasons
- Fix clippy warnings for unused variables and float comparisons
- Standardize numeric literal formatting with underscores
- Remove redundant all() wrappers in cfg conditions
- Update core imports to prefer core over std where applicable
diff --git a/module/alias/winterval/examples/winterval_non_iterable.rs b/module/alias/winterval/examples/winterval_non_iterable.rs
@@ -3,7 +3,7 @@
 fn main() {
   use winterval::{NonIterableInterval, IntoInterval, Bound};
 
-  fn f1(interval: impl NonIterableInterval) {
+  fn f1(interval: &impl NonIterableInterval) {
     println!(
       "Do something with this {:?} .. {:?} interval",
       interval.left(),
@@ -12,12 +12,12 @@ fn main() {
   }
 
   // Iterable/bound interval from tuple.
-  f1((Bound::Included(0), Bound::Included(3)).into_interval());
+  f1(&(Bound::Included(0), Bound::Included(3)).into_interval());
   // Non-iterable/unbound interval from tuple.
-  f1((Bound::Included(0), Bound::Unbounded).into_interval());
+  f1(&(Bound::Included(0), Bound::Unbounded).into_interval());
   // Non-iterable/unbound interval from `core::ops::RangeFrom`.
-  f1(0..);
+  f1(&(0..));
   // Non-iterable/unbound interval from `core::ops::RangeFull`
   // what is ( -Infinity .. +Infinity ).
-  f1(..);
+  f1(&(..));
 }
diff --git a/module/core/component_model_types/examples/component_model_types_trivial.rs b/module/core/component_model_types/examples/component_model_types_trivial.rs
@@ -51,7 +51,7 @@ fn main() {
     }
   }
 
-  let mut got: Person = Default::default();
+  let mut got: Person = Person::default();
   got.assign(13);
   got.assign("John");
   assert_eq!(
diff --git a/module/core/component_model_types/tests/inc/mod.rs b/module/core/component_model_types/tests/inc/mod.rs
@@ -10,12 +10,12 @@ mod components_tests {
   #[ cfg( feature = "types_component_assign" ) ]
   mod component_assign_manual;
 
-  #[cfg(all(feature = "types_component_assign"))]
+  #[cfg(feature = "types_component_assign")]
   mod components_assign_manual;
 
   // #[ cfg( all( feature = "derive_from_components" ) ) ]
   mod from_components_manual;
 
-  #[cfg(all(feature = "types_component_assign"))]
+  #[cfg(feature = "types_component_assign")]
   mod composite_manual;
 }
diff --git a/module/core/data_type/tests/smoke_test.rs b/module/core/data_type/tests/smoke_test.rs
@@ -1,12 +1,12 @@
 //! Smoke testing of the package.
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn local_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
 }
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn published_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
diff --git a/module/core/format_tools/tests/inc/test_object.rs b/module/core/format_tools/tests/inc/test_object.rs
@@ -10,13 +10,13 @@ use the_module::
   OptionalCow,
 };
 
-use std::
+use core::
 {
   hash::Hasher,
   hash::Hash,
   cmp::Ordering,
-  borrow::Cow,
 };
+use std::borrow::Cow;
 
 use collection_tools::HashMap;
 
diff --git a/module/core/former_types/examples/former_types_trivial.rs b/module/core/former_types/examples/former_types_trivial.rs
@@ -51,7 +51,7 @@ fn main() {
     }
   }
 
-  let mut got: Person = Default::default();
+  let mut got: Person = Person::default();
   got.assign(13);
   got.assign("John");
   assert_eq!(
diff --git a/module/core/interval_adapter/examples/interval_adapter_non_iterable.rs b/module/core/interval_adapter/examples/interval_adapter_non_iterable.rs
@@ -2,7 +2,7 @@
 fn main() {
   use interval_adapter::{NonIterableInterval, IntoInterval, Bound};
 
-  fn f1(interval: impl NonIterableInterval) {
+  fn f1(interval: &impl NonIterableInterval) {
     println!(
       "Do something with this {:?} .. {:?} interval",
       interval.left(),
@@ -11,12 +11,12 @@ fn main() {
   }
 
   // Iterable/bound interval from tuple.
-  f1((Bound::Included(0), Bound::Included(3)).into_interval());
+  f1(&(Bound::Included(0), Bound::Included(3)).into_interval());
   // Non-iterable/unbound interval from tuple.
-  f1((Bound::Included(0), Bound::Unbounded).into_interval());
+  f1(&(Bound::Included(0), Bound::Unbounded).into_interval());
   // Non-iterable/unbound interval from `core::ops::RangeFrom`.
-  f1(0..);
+  f1(&(0..));
   // Non-iterable/unbound interval from `core::ops::RangeFull`
   // what is ( -Infinity .. +Infinity ).
-  f1(..);
+  f1(&(..));
 }
diff --git a/module/core/mod_interface_meta/tests/smoke_test.rs b/module/core/mod_interface_meta/tests/smoke_test.rs
@@ -1,12 +1,12 @@
 //! Smoke testing of the package.
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn local_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
 }
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn published_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
diff --git a/module/core/process_tools/tests/smoke_test.rs b/module/core/process_tools/tests/smoke_test.rs
@@ -1,12 +1,12 @@
 //! Smoke testing of the package.
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn local_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
 }
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn published_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
diff --git a/module/core/process_tools/tests/tool/asset.rs b/module/core/process_tools/tests/tool/asset.rs
@@ -104,6 +104,7 @@ pub struct ProgramRun {
 
 #[ derive( Debug ) ]
 #[ allow( dead_code ) ]
+#[ allow( clippy::enum_variant_names ) ]
 pub enum GetData {
   FromStr(&'static str),
   FromBin(&'static [u8]),
diff --git a/module/core/time_tools/tests/smoke_test.rs b/module/core/time_tools/tests/smoke_test.rs
@@ -1,12 +1,12 @@
 //! Smoke testing of the package.
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn local_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues
 }
 
-#[ ignore ]
+#[ ignore = "temporarily disabled due to test_tools::test module gating issues" ]
 #[ test ]
 fn published_smoke_test() {
   // xxx: temporarily disabled due to test_tools::test module gating issues  
diff --git a/module/move/crates_tools/tests/smoke_test.rs b/module/move/crates_tools/tests/smoke_test.rs
@@ -5,7 +5,7 @@ fn local_smoke_test() {
   println!("Local smoke test passed");
 }
 
-#[ignore]
+#[ignore = "smoke test for published version"]
 #[test]
 fn published_smoke_test() {
   println!("Published smoke test passed");
diff --git a/module/move/deterministic_rand/examples/sample_deterministic_rand_rayon.rs b/module/move/deterministic_rand/examples/sample_deterministic_rand_rayon.rs
@@ -12,6 +12,7 @@
 use rayon::prelude::*;
 use deterministic_rand::{distributions::Uniform, Rng, Hrng};
 
+#[allow(clippy::float_cmp)]
 fn main() {
   // Define a range for random number generation between -1.0 and 1.0.
   let range = Uniform::new(-1.0f64, 1.0);
@@ -61,7 +62,7 @@ fn main() {
 
   // If determinism is enabled, assert that the calculated value of Pi matches the expected result.
   #[cfg(feature = "determinism")]
-  assert_eq!(got_pi, 3.1410448);
+  assert_eq!(got_pi, 3.141_044_8);
 
   // Print the calculated value of Pi.
   println!("PI = {got_pi}");
diff --git a/module/move/deterministic_rand/examples/sample_deterministic_rand_std.rs b/module/move/deterministic_rand/examples/sample_deterministic_rand_std.rs
@@ -12,7 +12,7 @@ fn main() {
 
   // Convert the HashMap into an iterator, apply deterministic sorting to the keys,
   // and then map each (key, value) pair to just the value.
-  let _keys: Vec<_> = map
+  let keys: Vec<_> = map
     .into_iter()
     .if_determinism_then_sort_by(|(a, _), (b, _)| a.cmp(b))
     .map(|e| e.1)
@@ -22,5 +22,5 @@ fn main() {
   // This is a conditional compilation check that ensures the code block is compiled and run only
   // if the 'determinism' feature is enabled.
   #[cfg(feature = "determinism")]
-  assert_eq!(_keys, vec!["first", "second", "third"]);
+  assert_eq!(keys, vec!["first", "second", "third"]);
 }
diff --git a/module/move/deterministic_rand/src/hrng_non_deterministic.rs b/module/move/deterministic_rand/src/hrng_non_deterministic.rs
@@ -17,7 +17,8 @@ mod private {
   impl SharedGenerator {
     /// Emulate lock of a mutex.
     #[inline(always)]
-    pub fn lock(&self) -> SharedGeneratorLock {
+    #[allow(clippy::unused_self)]
+    pub fn lock(self) -> SharedGeneratorLock {
       SharedGeneratorLock
     }
   }
@@ -29,7 +30,8 @@ mod private {
   impl SharedGeneratorLock {
     /// Emulate unwrap of a result of guard produced my locking a mutex.
     #[inline(always)]
-    pub fn unwrap(&self) -> DerefRng {
+    #[allow(clippy::unused_self)]
+    pub fn unwrap(self) -> DerefRng {
       DerefRng(rand::thread_rng())
     }
   }
@@ -79,6 +81,7 @@ mod private {
     /// let got : u64 = rng.gen();
     /// ```
     #[inline(always)]
+    #[must_use]
     pub fn master() -> Self {
       Self
     }
@@ -113,12 +116,14 @@ mod private {
     /// let got : u64 = rng.gen();
     /// ```
     #[inline(always)]
+    #[must_use]
     pub fn rng_ref(&self) -> SharedGenerator {
       SharedGenerator
     }
 
     /// Creates new child hierarchical random number generator by index seed.
     #[inline(always)]
+    #[must_use]
     pub fn child(&self, _: usize) -> Self {
       Self
     }
@@ -132,6 +137,7 @@ mod private {
 
     /// Returns number of children created by this generator.
     #[inline(always)]
+    #[must_use]
     pub fn _children_len(&self) -> usize {
       0
     }
diff --git a/module/move/deterministic_rand/tests/assumption_test.rs b/module/move/deterministic_rand/tests/assumption_test.rs
@@ -158,8 +158,8 @@ fn assumption_streams_switching() {
   use rand::{RngCore, SeedableRng};
   use rand_chacha::ChaCha8Rng;
 
-  let a = 6234031553773679537;
-  let b = 5421492469564588225;
+  let a = 6_234_031_553_773_679_537;
+  let b = 5_421_492_469_564_588_225;
 
   let mut master = ChaCha8Rng::seed_from_u64(13);
   master.set_stream(0);
@@ -188,8 +188,8 @@ fn assumption_streams_same_source() {
   use rand::{RngCore, SeedableRng};
   use rand_chacha::ChaCha8Rng;
 
-  let a = 6234031553773679537;
-  let b = 2305422516838604614;
+  let a = 6_234_031_553_773_679_537;
+  let b = 2_305_422_516_838_604_614;
 
   let mut master = ChaCha8Rng::seed_from_u64(13);
   master.set_stream(0);

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ fn main() {`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`- let mut got: Person = Default::default();`
	`54`	`+ let mut got: Person = Person::default();`
`55`	`55`	`got.assign(13);`
`56`	`56`	`got.assign("John");`
`57`	`57`	`assert_eq!(`