warpdroid: address Copilot review on blank-URL guards and StrictMode

- StrictMode: guard detectUnbufferedIo() under SDK_INT >= O. The call
  was unconditional and minSdk is 24, so debug builds on Android 7.x
  would NoSuchMethodError on Application.onCreate.
- DrawerImageLoader.set: cancel any in-flight Glide request on the
  recycled ImageView before showing the placeholder, so a stale
  callback from a previous profile can't overwrite it.
- loadDrawerAvatar: blank avatar URL now plants the default avatar on
  the toolbar navigation icon instead of returning silently and
  leaving whatever icon was there from the previous profile.
- EditProfileActivity: blank avatar branch now sets the default avatar
  drawable on the preview ImageView (the XML has no src fallback, so
  users without an avatar previously saw an empty preview).

Author: claude

version

@@ -1 +1 @@
-0.7.16
+0.7.17

warpdroid/app/src/main/java/site/warpnet/warpdroid/EditProfileActivity.kt

@@ -199,17 +199,25 @@ class EditProfileActivity : BaseActivity() {
                             binding.addFieldButton.isVisible =
                                 (me.source?.fields?.size ?: 0) < maxAccountFields
 
-                            if (viewModel.avatarData.value == null && me.avatar.isNotBlank()) {
-                                Glide.with(this@EditProfileActivity)
-                                    .load(me.avatar)
-                                    .placeholder(R.drawable.avatar_default)
-                                    .transform(
-                                        FitCenter(),
-                                        RoundedCorners(
-                                            resources.getDimensionPixelSize(R.dimen.avatar_radius_80dp)
+                            if (viewModel.avatarData.value == null) {
+                                if (me.avatar.isNotBlank()) {
+                                    Glide.with(this@EditProfileActivity)
+                                        .load(me.avatar)
+                                        .placeholder(R.drawable.avatar_default)
+                                        .transform(
+                                            FitCenter(),
+                                            RoundedCorners(
+                                                resources.getDimensionPixelSize(R.dimen.avatar_radius_80dp)
+                                            )
                                         )
-                                    )
-                                    .into(binding.avatarPreview)
+                                        .into(binding.avatarPreview)
+                                } else {
+                                    // Profile has no avatar — fall back to
+                                    // the same default that Glide would have
+                                    // used as a placeholder, otherwise the
+                                    // preview shows an empty ImageView.
+                                    binding.avatarPreview.setImageResource(R.drawable.avatar_default)
+                                }
                             }
 
                             if (viewModel.headerData.value == null && me.header.isNotBlank()) {

warpdroid/app/src/main/java/site/warpnet/warpdroid/MainActivity.kt

@@ -63,6 +63,7 @@ import androidx.viewpager2.widget.MarginPageTransformer
 import com.bumptech.glide.Glide
 import com.bumptech.glide.load.resource.bitmap.RoundedCorners
 import com.bumptech.glide.request.target.CustomTarget
+import androidx.core.content.ContextCompat
 import com.bumptech.glide.request.target.FixedSizeDrawable
 import com.bumptech.glide.request.transition.Transition
 import com.google.android.material.R as materialR
@@ -580,8 +581,11 @@ class MainActivity : BottomSheetActivity(), ActionButtonActivity, MenuProvider {
                 // Warpnet has no HTTP URLs for headers/avatars in some
                 // states (newly-paired profile, etc.); skip the Glide
                 // request entirely so logcat isn't spammed with
-                // "Load failed for []" for an empty Uri.
+                // "Load failed for []" for an empty Uri. Cancel any
+                // in-flight request on this recycled ImageView first so
+                // a stale callback can't overwrite the placeholder.
                 if (uri.toString().isBlank()) {
+                    Glide.with(imageView).clear(imageView)
                     imageView.setImageDrawable(placeholder)
                     return
                 }
@@ -860,7 +864,6 @@ class MainActivity : BottomSheetActivity(), ActionButtonActivity, MenuProvider {
 
     @SuppressLint("CheckResult")
     private fun loadDrawerAvatar(avatarUrl: String, showPlaceholder: Boolean = true) {
-        if (avatarUrl.isBlank()) return
         val hideTopToolbar = preferences.getBoolean(PrefKeys.HIDE_TOP_TOOLBAR, false)
         val animateAvatars = preferences.getBoolean(PrefKeys.ANIMATE_GIF_AVATARS, false)
 
@@ -877,6 +880,16 @@ class MainActivity : BottomSheetActivity(), ActionButtonActivity, MenuProvider {
 
         val navIconSize = resources.getDimensionPixelSize(R.dimen.avatar_toolbar_nav_icon_size)
 
+        if (avatarUrl.isBlank()) {
+            // No URL to load — set the default avatar on the toolbar
+            // instead of letting Glide log "Load failed for []" or
+            // leaving the nav icon stale from a previous profile.
+            ContextCompat.getDrawable(this, R.drawable.avatar_default)?.let {
+                activeToolbar.navigationIcon = FixedSizeDrawable(it, navIconSize, navIconSize)
+            }
+            return
+        }
+
         if (animateAvatars) {
             Glide.with(this)
                 .asDrawable()

warpdroid/app/src/main/java/site/warpnet/warpdroid/WarpdroidApplication.kt

@@ -91,15 +91,17 @@ class WarpdroidApplication :
         // StrictMode off — penalties are intentionally log-only so a
         // missed read doesn't crash a user.
         if (BuildConfig.DEBUG) {
-            StrictMode.setThreadPolicy(
-                StrictMode.ThreadPolicy.Builder()
-                    .detectDiskReads()
-                    .detectDiskWrites()
-                    .detectNetwork()
-                    .detectUnbufferedIo()
-                    .penaltyLog()
-                    .build()
-            )
+            val threadPolicy = StrictMode.ThreadPolicy.Builder()
+                .detectDiskReads()
+                .detectDiskWrites()
+                .detectNetwork()
+                .penaltyLog()
+            // detectUnbufferedIo requires API 26 (O); minSdk is 24 so
+            // guarding it avoids NoSuchMethodError on Android 7.x.
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+                threadPolicy.detectUnbufferedIo()
+            }
+            StrictMode.setThreadPolicy(threadPolicy.build())
             StrictMode.setVmPolicy(
                 StrictMode.VmPolicy.Builder()
                     .detectLeakedClosableObjects()