Skip to content

Commit 7a3c6dd

Browse files
authored
Merge pull request #74 from Dratejinn/release/4.0.0
Release/4.0.0
2 parents 197f405 + 85fc298 commit 7a3c6dd

File tree

8 files changed

+180
-253
lines changed

8 files changed

+180
-253
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.1.5
1+
4.0.0

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"require": {
2222
"php": "^7.4.0 || ^8.0.0",
2323
"ext-sockets": "*",
24-
"psr/log": "^1.0"
24+
"psr/log": "^1.0 || ^2.0 || ^3.0"
2525
},
2626
"autoload": {
2727
"psr-4": {
@@ -48,7 +48,7 @@
4848
],
4949
"config": {
5050
"platform": {
51-
"php": "7.4"
51+
"php": "8.1"
5252
}
5353
}
5454
}

composer.lock

Lines changed: 158 additions & 140 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/PHPWebSockets.php

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -129,26 +129,11 @@ final class PHPWebSockets {
129129
511 => 'Network Authentication Required',
130130
];
131131

132-
/**
133-
* If we should add debug traces in the constructor of AUpdate
134-
*
135-
* @var bool
136-
*/
137-
private static $_TraceAllUpdates = FALSE;
132+
private static bool $_TraceAllUpdates = FALSE;
138133

139-
/**
140-
* The current version of PHPWebSockets
141-
*
142-
* @var string|null
143-
*/
144-
private static $_Version = NULL;
134+
private static ?string $_Version = NULL;
145135

146-
/**
147-
* The log handler function
148-
*
149-
* @var \Psr\Log\LoggerInterface
150-
*/
151-
private static $_Logger = NULL;
136+
private static ?LoggerInterface $_Logger = NULL;
152137

153138
/**
154139
* Checks for updates for the provided IStreamContainer objects
@@ -483,7 +468,10 @@ public static function SetTraceAllUpdates(bool $value) : void {
483468
* @return void
484469
*/
485470
public static function Log(string $logLevel, $message, array $context = []) : void {
486-
self::GetLogger()->log($logLevel, $message, $context);
471+
$logger = self::getLogger();
472+
if ($logger) {
473+
$logger->log($logLevel, $message, $context);
474+
}
487475
}
488476

489477
/**
@@ -502,12 +490,7 @@ public static function SetLogger(LoggerInterface $logger) : void {
502490
*
503491
* @return \Psr\Log\LoggerInterface
504492
*/
505-
public static function GetLogger() : LoggerInterface {
506-
507-
if (self::$_Logger === NULL) {
508-
self::$_Logger = new \PHPWebSockets\BasicLogger();
509-
}
510-
493+
public static function GetLogger() : ?LoggerInterface {
511494
return self::$_Logger;
512495
}
513496

src/PHPWebSockets/BasicLogger.php

Lines changed: 0 additions & 69 deletions
This file was deleted.

src/PHPWebSockets/Server/AcceptingConnection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function __construct(Server $server, $stream) {
6464

6565
// Inherit the logger from the server
6666
$serverLogger = $server->getLogger();
67-
if ($serverLogger !== \PHPWebSockets::GetLogger()) {
67+
if ($serverLogger && $serverLogger !== \PHPWebSockets::GetLogger()) {
6868
$this->setLogger($serverLogger);
6969
}
7070

src/PHPWebSockets/Server/Connection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public function __construct(Server $server, $stream, string $streamName, int $in
9797

9898
// Inherit the logger from the server
9999
$serverLogger = $server->getLogger();
100-
if ($serverLogger !== \PHPWebSockets::GetLogger()) {
100+
if ($serverLogger && $serverLogger !== \PHPWebSockets::GetLogger()) {
101101
$this->setLogger($serverLogger);
102102
}
103103

src/PHPWebSockets/TLogAware.php

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,7 @@
3434

3535
trait TLogAware {
3636

37-
/**
38-
* The logger
39-
*
40-
* @var \Psr\Log\LoggerInterface|null
41-
*/
42-
protected $_logger = NULL;
37+
protected ?LoggerInterface $_logger = NULL;
4338

4439
/**
4540
* Sets the logger
@@ -57,10 +52,9 @@ public function setLogger(LoggerInterface $logger) : void {
5752
*
5853
* @return \Psr\Log\LoggerInterface
5954
*/
60-
public function getLogger() : LoggerInterface {
61-
55+
public function getLogger() : ?LoggerInterface {
6256
if ($this->_logger === NULL) {
63-
return \PHPWebSockets::GetLogger();
57+
$this->_logger = \PHPWebSockets::GetLogger();
6458
}
6559

6660
return $this->_logger;
@@ -76,10 +70,11 @@ public function getLogger() : LoggerInterface {
7670
* @return void
7771
*/
7872
protected function _log(string $level, string $message, array $context = []) : void {
79-
80-
$this->getLogger()->log($level, $message, array_merge([
81-
'subject' => $this,
82-
], $context));
83-
73+
$logger = $this->getLogger();
74+
if ($logger) {
75+
$logger->log($level, $message, array_merge([
76+
'subject' => $this,
77+
], $context));
78+
}
8479
}
8580
}

0 commit comments

Comments
 (0)