Skip to content

Commit 96aa2cd

Browse files
committed
Revert "Change to CMD-checks to avoid failing on non fatal warnings"
This reverts commit acacbcf. Github action is generated by utils package to mimic R CMD checks, and therefore should not be altered. If warnings or errors are shown, they need to be fixed instead.
1 parent c653c8b commit 96aa2cd

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

.github/workflows/R-CMD-check.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,5 @@ jobs:
4747

4848
- uses: r-lib/actions/check-r-package@v2
4949
with:
50-
args: 'c("--no-manual","--as-cran","--no-examples")'
51-
error-on: '"error"'
52-
env:
53-
_R_CHECK_FORCE_SUGGESTS_: "false"
54-
R_REMOTES_NO_ERRORS_FROM_WARNINGS: "true"
55-
50+
upload-snapshots: true
51+
build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'

R/caption_groups.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ caption_group <- function(df = NULL,
4141
if (!is.null(contribs_tbl) &&
4242
all(c("changesets", "first_edit", "last_edit") %in% base::names(contribs_tbl))) {
4343
rng <- base::range(c(contribs_tbl$first_edit, contribs_tbl$last_edit), na.rm = TRUE)
44-
days <- as.numeric(base::diff(rng)) + 1
44+
days <- as.numeric(stats::diff(rng)) + 1
4545
total_changesets <- base::sum(contribs_tbl$changesets, na.rm = TRUE)
4646
per_day <- ifelse(days > 0, total_changesets / days, total_changesets)
4747
} else if (!is.null(df) && "date" %in% base::names(df)) {

0 commit comments

Comments
 (0)