fix table addressing to externel graphical arrays; add limitation to the docs

Author: dromer

docs/02.getting_started.md

@@ -44,6 +44,8 @@ When externing a table using `@hv_table` annotation, or appending it after the n
 
 `[table array1 100 @hv_table]`
 
+Using spaces in array names is no longer supported.
+
 ### GUI Objects
 
 Most GUI objects will also accept send/receive configurations. These will be converted to send/receive objects in the Control Graph.
@@ -130,3 +132,4 @@ This list will be continuously epanded to document differences in object behavio
 * Right inlet for table onset of `[tabread4~]` does not do anything.
 * Right inlet for `[lop~]` does not support signal input.
 * Heavy does not support multichannel connections.
+* Arrays do not support spaces in the name.

hvcc/interpreters/pd2hv/HeavyObject.py

@@ -61,6 +61,20 @@ def __init__(
         obj_args = obj_args or []
         self.obj_dict = {}
 
+        # clean up externed tables
+        if obj_type in (
+            "__var",
+            "__tabwrite",
+            "__tabwrite~f",
+            "__tabwrite_stoppable~f",
+            "__tabread",
+            "__tabread~f",
+            "__tabread~if",
+            "__tabread_stoppable~f"
+        ):
+            for i, a in enumerate(obj_args):
+                obj_args[i] = a.split(" ")[0] if "@hv_table" in a else a
+
         for i, a in enumerate(self.__obj_dict.args):
             arg = cast(Union[IRArg, LangArg], a)
             # if the argument exists (and has been correctly resolved)
@@ -91,7 +105,7 @@ def __init__(
 
         # send/receive, table, etc. must have public scope
         # TODO(mhroth): dirty
-        if obj_type in ["table", "__table", "send", "__send", "receive", "__receive"]:
+        if obj_type in ("table", "__table", "send", "__send", "receive", "__receive"):
             self.__annotations["scope"] = "public"
 
     @classmethod

tests/pd/control/test-tabwrite_hv_table.golden.txt

@@ -0,0 +1,6 @@
+[@ 0.000] print: 0
+[@ 0.000] print: 0
+[@ 0.000] print: 0
+[@ 0.000] print: 2
+[@ 0.000] print: -100
+[@ 0.000] print: 1

tests/pd/control/test-tabwrite_hv_table.pd

@@ -0,0 +1,60 @@
+#N canvas 750 181 444 399 10;
+#N canvas 0 22 450 278 (subpatch) 0;
+#X array array1\ @hv_table 3 float 2;
+#X coords 0 1 3 -1 200 140 1 0 0;
+#X restore 192 293 graph;
+#X obj 21 6 loadbang;
+#X obj 24 330 print;
+#X msg 85 267 0;
+#X msg 55 267 1;
+#X msg 25 267 2;
+#X obj 22 231 t b b b;
+#X obj 287 139 t b b;
+#X msg 290 178 2;
+#X msg 322 178 0;
+#X obj 217 139 t b b;
+#X msg 252 178 1;
+#X msg 220 178 120;
+#X obj 153 143 t b b;
+#X obj 83 143 t b b;
+#X msg 192 182 1;
+#X msg 153 182 -100;
+#X msg 115 182 2;
+#X msg 83 182 1;
+#X obj 21 80 t b b b;
+#X obj 84 113 t b b b b;
+#X obj 98 234 tabwrite array1\ @hv_table;
+#X obj 24 308 tabread array1\ @hv_table;
+#X obj 21 39 bng 25 250 50 0 empty empty empty 17 7 0 10 #191919 #ffffff #ffffff;
+#X connect 1 0 23 0;
+#X connect 3 0 22 0;
+#X connect 4 0 22 0;
+#X connect 5 0 22 0;
+#X connect 6 0 5 0;
+#X connect 6 1 4 0;
+#X connect 6 2 3 0;
+#X connect 7 0 8 0;
+#X connect 7 1 9 0;
+#X connect 8 0 21 0;
+#X connect 9 0 21 1;
+#X connect 10 0 12 0;
+#X connect 10 1 11 0;
+#X connect 11 0 21 1;
+#X connect 12 0 21 0;
+#X connect 13 0 16 0;
+#X connect 13 1 15 0;
+#X connect 14 0 18 0;
+#X connect 14 1 17 0;
+#X connect 15 0 21 1;
+#X connect 16 0 21 0;
+#X connect 17 0 21 1;
+#X connect 18 0 21 0;
+#X connect 19 0 6 0;
+#X connect 19 1 20 0;
+#X connect 19 2 6 0;
+#X connect 20 0 14 0;
+#X connect 20 1 13 0;
+#X connect 20 2 10 0;
+#X connect 20 3 7 0;
+#X connect 22 0 2 0;
+#X connect 23 0 19 0;

tests/test_control.py

@@ -276,6 +276,9 @@ def test_tabread(self):
     def test_tabwrite(self):
         self._test_control_patch("test-tabwrite.pd")
 
+    def test_tabwrite_hv_table(self):
+        self._test_control_patch("test-tabwrite_hv_table.pd")
+
     def test_tan(self):
         self._test_control_patch("test-tan.pd")