Skip to content

added tests for external plots module#263

Open
ryliefoster wants to merge 15 commits intoWaterLily-jl:masterfrom
ryliefoster:master
Open

added tests for external plots module#263
ryliefoster wants to merge 15 commits intoWaterLily-jl:masterfrom
ryliefoster:master

Conversation

@ryliefoster
Copy link
Copy Markdown

started tests for external plots module, which works by generating figures and comparing them to pre-generated figures.

ryliefoster and others added 3 commits November 18, 2025 18:47
…gures and comparing them to pre-generated figures.
started tests for external plots module, which works by generating fi…
@ryliefoster
Copy link
Copy Markdown
Author

Before I go forward, I was wondering if it is alright for me to add a file to the test suite to store data (gifs, images, logs, etc.) for the the PlotsExt method outputs to be compaired to when the tests are run.

@b-fg
Copy link
Copy Markdown
Member

b-fg commented Nov 25, 2025

That should be fine, as long as they are stored in test/, are small, and just a few.

@ryliefoster
Copy link
Copy Markdown
Author

That should be fine, as long as they are stored in test/, are small, and just a few.

Ok, thanks!

@ryliefoster ryliefoster marked this pull request as ready for review December 7, 2025 23:56
@ryliefoster ryliefoster changed the title started tests for external plots module (WIP) started tests for external plots module Dec 7, 2025
@ryliefoster ryliefoster changed the title started tests for external plots module added tests for external plots module Dec 7, 2025
@ryliefoster
Copy link
Copy Markdown
Author

I think the tests are ready now. Are the added modules to maintests alright?

@b-fg
Copy link
Copy Markdown
Member

b-fg commented Dec 28, 2025

I have cleaned up the Project.toml (Plots needs to be in extras and targets to be used in Tests). I have also merged the current master branch. There are 2 tests not passing currently (Julia 1.11.5):

WaterLilyPlotsExt.jl: Test Failed at /home/b-fg/Workspace/tudelft1/WaterLily.jl/test/maintests.jl:688
  Expression: abs(maximum(channelview(testgif) - channelview(compgif))) < 1
   Evaluated: 1.0N0f8 < 1

and

WaterLilyPlotsExt.jl: Test Failed at /home/b-fg/Workspace/tudelft1/WaterLily.jl/test/maintests.jl:731
  Expression: abs(maximum(channelview(test) - channelview(comp))) < 1
   Evaluated: 1.0N0f8 < 1

You may want to take a look at these :)

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weymouth
Copy link
Copy Markdown
Member

Any further progress on this?

@ryliefoster
Copy link
Copy Markdown
Author

Some other work pulled me away from this, sorry about that! I'll reacquaint myself with the tests and try to have this fixed this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants