added tests for external plots module#263
added tests for external plots module#263ryliefoster wants to merge 15 commits intoWaterLily-jl:masterfrom
Conversation
…gures and comparing them to pre-generated figures.
started tests for external plots module, which works by generating fi…
|
Before I go forward, I was wondering if it is alright for me to add a file to the test suite to store data (gifs, images, logs, etc.) for the the PlotsExt method outputs to be compaired to when the tests are run. |
|
That should be fine, as long as they are stored in test/, are small, and just a few. |
Ok, thanks! |
added tests for flood
added images for flood tests
added bodyplot tests and fixed an error with running consecutive tests
added tests and test data for plot_logger
|
I think the tests are ready now. Are the added modules to maintests alright? |
|
I have cleaned up the Project.toml (Plots needs to be in WaterLilyPlotsExt.jl: Test Failed at /home/b-fg/Workspace/tudelft1/WaterLily.jl/test/maintests.jl:688
Expression: abs(maximum(channelview(testgif) - channelview(compgif))) < 1
Evaluated: 1.0N0f8 < 1and WaterLilyPlotsExt.jl: Test Failed at /home/b-fg/Workspace/tudelft1/WaterLily.jl/test/maintests.jl:731
Expression: abs(maximum(channelview(test) - channelview(comp))) < 1
Evaluated: 1.0N0f8 < 1You may want to take a look at these :) |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Any further progress on this? |
|
Some other work pulled me away from this, sorry about that! I'll reacquaint myself with the tests and try to have this fixed this week. |
started tests for external plots module, which works by generating figures and comparing them to pre-generated figures.