Skip to content
This repository was archived by the owner on Feb 15, 2019. It is now read-only.
This repository was archived by the owner on Feb 15, 2019. It is now read-only.

Make AsyncEvent behavior less confusing. #5

@minecrafter

Description

@minecrafter

Events that extend AsyncEvent do not play well with most listeners.

AsyncEvent allows you to callback when you are done with an event. In practice, this concept is almost always confusing and incompatible (i.e. ProxyPingEvent becoming an async event).

There's a couple of solutions to this:

  • Deprecate AsyncEvent and add in new Async*Event classes to replace them. These new events would get called before the regular events. This is the easiest approach, and this is what Bukkit does.
  • Run all asynchronous handlers before synchronous ones. Tricky to implement as it requires changes to EventBus and requires plugin updates.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions