Skip to content

Generator's minor issues #2

@NewEXE

Description

@NewEXE
  1. generates hardcoded value instead of dynamic one in actionTypes tpl: https://github.com/CodeTiburon/schematics-react/blob/master/src/module/files/__name%40camelize%40if-flat__/actionTypes.__jsext__#L8
  2. also need to add line to actionTypes template
    export const SAVE_ALL = '<%= camelize(name) %>/SAVE_ALL';
  3. add ; (semicolon) at the end of line: https://github.com/CodeTiburon/schematics-react/blob/master/src/service/files/__name%40camelize%40if-flat__.service.__jsext__#L12
  4. replace
    params: { page: 1, per_page: constants.ITEMS_PER_PAGE, order_by: orderBy, order_type: orderType },
    with
    params: { page: page || 1, per_page: constants.ITEMS_PER_PAGE, order_by: orderBy, order_type: orderType },
    params: { page: 1, per_page: constants.ITEMS_PER_PAGE, order_by: orderBy, order_type: orderType },

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions