Item Equipped: Force "exact match" mode

Unfortunately the wow api's C_Item.IsEquippedItem does not work
correctly if passed an item name. If there are multiple items with the
same name, it only checks one item id.

A previous commit checked each slot, but that lead to performance
problems due to how many checks that needs.

Fix this, by removing support for "names" and only support item ids.
Thus the user has full control on which item ids are checked.

Fixes: #5710

Author: InfusOnWoW

WeakAuras/GenericTrigger.lua

@@ -5133,11 +5133,7 @@ WeakAuras.CheckForItemEquipped = function(itemId, specificSlot)
   else
     local item = Item:CreateFromEquipmentSlot(specificSlot)
     if item and not item:IsItemEmpty() then
-      if type(itemId) == "number" then
-        return itemId == item:GetItemID()
-      else
-        return itemId == item:GetItemName()
-      end
+      return itemId == item:GetItemID()
     end
   end
 end

WeakAuras/Prototypes.lua

@@ -2042,8 +2042,9 @@ Private.load_prototype = {
       multiEntry = {
         operator = "or"
       },
-      test = "C_Item.IsEquippedItem(C_Item.GetItemInfo(%s) or '')",
-      events = { "UNIT_INVENTORY_CHANGED", "PLAYER_EQUIPMENT_CHANGED"}
+      test = "C_Item.IsEquippedItem(%s or '')",
+      events = { "UNIT_INVENTORY_CHANGED", "PLAYER_EQUIPMENT_CHANGED"},
+      only_exact = true,
     },
     {
       name = "not_itemequiped",
@@ -2052,8 +2053,9 @@ Private.load_prototype = {
       multiEntry = {
         operator = "or"
       },
-      test = "not C_Item.IsEquippedItem(C_Item.GetItemInfo(%s) or '')",
-      events = { "UNIT_INVENTORY_CHANGED", "PLAYER_EQUIPMENT_CHANGED"}
+      test = "not C_Item.IsEquippedItem(%s or '')",
+      events = { "UNIT_INVENTORY_CHANGED", "PLAYER_EQUIPMENT_CHANGED"},
+      only_exact = true,
     },
     {
       name = "itemtypeequipped",
@@ -8742,17 +8744,10 @@ Private.event_prototypes = {
         local itemSlot = %s
       ]]
 
-      if trigger.use_exact_itemName then
-        ret = ret ..[[
-          local itemName = triggerItemName
-          local equipped = WeakAuras.CheckForItemEquipped(triggerItemName, itemSlot)
-        ]]
-      else
-        ret = ret ..[[
-          local itemName = C_Item.GetItemInfo(triggerItemName)
-          local equipped = WeakAuras.CheckForItemEquipped(itemName, itemSlot)
-        ]]
-      end
+      ret = ret ..[[
+        local itemName = triggerItemName
+        local equipped = WeakAuras.CheckForItemEquipped(triggerItemName, itemSlot)
+      ]]
 
       return ret:format(trigger.use_inverse and "true" or "false", itemName, trigger.use_itemSlot and trigger.itemSlot or "nil");
     end,
@@ -8769,7 +8764,7 @@ Private.event_prototypes = {
         type = "item",
         required = true,
         test = "true",
-        showExactOption = true
+        only_exact = true
       },
       {
         name = "itemId",

WeakAurasOptions/LoadOptions.lua

@@ -703,6 +703,7 @@ function OptionsPrivate.ConstructOptions(prototype, data, startorder, triggernum
               local value = getValue(trigger, "use_"..realname, realname, multiEntry, entryNumber)
               if(arg.type == "item") then
                 local useExactSpellId = (arg.showExactOption and getValue(trigger, nil, "use_exact_"..realname, multiEntry, entryNumber))
+                                        or arg.only_exact
                 if value and value ~= "" then
                   if useExactSpellId then
                     local itemId = tonumber(value)
@@ -725,6 +726,7 @@ function OptionsPrivate.ConstructOptions(prototype, data, startorder, triggernum
                 end
               elseif(arg.type == "spell") then
                 local useExactSpellId = (arg.showExactOption and getValue(trigger, nil, "use_exact_"..realname, multiEntry, entryNumber))
+                                        or arg.only_exact
                 if value and value ~= "" and (type(value) == "number" or type(value) == "string") then
                   local spellID = WeakAuras.SafeToNumber(value)
                   if spellID then