Skip to content

TSU Helpers don't consistently allow omitting a return value #5821

Closed
@ljosberinn

Description

@ljosberinn

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

TSU Helpers such as :Update are listed as allow to not return a value, but in some cases, that still seems to be needed.

Reproduction aura: https://wago.io/Kt_yqAF-p

Relevant code section:

Image

In the export above, this is commented out, there's a return -- true in L209:

Image

The aura is tracking recent player casts. You can safely not care about the other code, the relevant branch is in the CLEU > Spell Cast Success branch.

WeakAuras Version

5.19.7

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error


Reproduction Steps

  1. cast a non-channel spell with a cast time
  2. note how the icon stays desaturated when the cast is over. the prints will indicate the state update for the spell cast
  3. comment in return true
  4. repeat and note how the spell cast successfully saturates upon success

Last Good Version

5.19.8

Screenshots

No response

Export String


Bisector Report


Metadata

Metadata

Assignees

No one assigned

    Labels

    ⏱ Awaiting ResponseThis ticket hasn't been triaged yet.🐛 BugThis is a problem with WeakAuras.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions