Some fixes

Author: stevenfontanella

src/passes/DeadStoreElimination.cpp

@@ -495,7 +495,7 @@ struct MemoryLogic : public ComparingLogic {
       // behavior - they trap on unaligned addresses. For simplicity, only
       // consider the case where atomicity is identical.
       // TODO: use ignoreImplicitTraps
-      if (store->isAtomic != load->isAtomic) {
+      if (store->isAtomic() != load->isAtomic()) {
         return false;
       }
 
@@ -516,7 +516,7 @@ struct MemoryLogic : public ComparingLogic {
       auto* store = store_->cast<Store>();
 
       // As in isLoadFrom, atomic stores are dangerous.
-      if (store->isAtomic != otherStore->isAtomic) {
+      if (store->isAtomic() != otherStore->isAtomic()) {
         return false;
       }
 
@@ -655,7 +655,9 @@ struct LocalDeadStoreElimination
   : public WalkerPass<PostWalker<LocalDeadStoreElimination>> {
   bool isFunctionParallel() { return true; }
 
-  Pass* create() { return new LocalDeadStoreElimination; }
+  std::unique_ptr<Pass> create() override {
+    return std::make_unique<LocalDeadStoreElimination>();
+  }
 
   void doWalkFunction(Function* func) {
     // Optimize globals.

test/lit/help/wasm-metadce.test

@@ -227,6 +227,9 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --intrinsic-lowering                          lower away binaryen intrinsics
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --ldse                                        removes dead stores (only
+;; CHECK-NEXT:                                                 looking at local info)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --legalize-and-prune-js-interface             legalizes the import/export
 ;; CHECK-NEXT:                                                 boundary and prunes when needed
 ;; CHECK-NEXT:

test/lit/help/wasm-opt.test

@@ -259,6 +259,9 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --intrinsic-lowering                          lower away binaryen intrinsics
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --ldse                                        removes dead stores (only
+;; CHECK-NEXT:                                                 looking at local info)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --legalize-and-prune-js-interface             legalizes the import/export
 ;; CHECK-NEXT:                                                 boundary and prunes when needed
 ;; CHECK-NEXT:

test/lit/help/wasm2js.test

@@ -191,6 +191,9 @@
 ;; CHECK-NEXT:
 ;; CHECK-NEXT:   --intrinsic-lowering                          lower away binaryen intrinsics
 ;; CHECK-NEXT:
+;; CHECK-NEXT:   --ldse                                        removes dead stores (only
+;; CHECK-NEXT:                                                 looking at local info)
+;; CHECK-NEXT:
 ;; CHECK-NEXT:   --legalize-and-prune-js-interface             legalizes the import/export
 ;; CHECK-NEXT:                                                 boundary and prunes when needed
 ;; CHECK-NEXT: