Skip to content

Commit 75d328f

Browse files
committed
Do not support JS strings beyond 2^32 bytes
1 parent 9e1a847 commit 75d328f

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

proposals/js-text-encoding-builtins/Overview.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ func encodeStringIntoUTF8Memory(
168168
string: externref,
169169
start: i64,
170170
end: i64
171-
) -> (i64, i64)
171+
) -> (i32, i64)
172172
{
173173
start >>>= 0;
174174
end >>>= 0;
@@ -213,3 +213,7 @@ The JS String Builtins proposal already exposes [`"wasm:js-string" "substring"`]
213213
### `"wasm:text-encoding"` vs `"wasm:js/text-encoding"`.
214214

215215
There is an [ongoing discussion](https://github.com/WebAssembly/esm-integration/issues/118) to change the mapping for JS builtins. Either convention works for us in this proposal.
216+
217+
### What about JS strings larger than 2^32 bytes?
218+
219+
Given that currently no engine supports strings larger than 2^30 and there are currently no plans to do so, we concluded to postpone specifically addressing this. See [#3](https://github.com/WebAssembly/js-text-encoding-builtins/issues/3).

0 commit comments

Comments
 (0)