Skip to content

Commit 8e24cc6

Browse files
committed
Pin CI runner images to explicit versions
CI is run infrequently enough on this repository that there's a nontrivial chance that GitHub updates the definition of `ubuntu-latest` for example between two CI runs. This can be confusing for contributors as PRs seemingly break CI when in reality they have nothing to do with the breakage and it's due to the image changing. This PR pins all images to the definition of `*-latest` at this time. The one exception is that one builder was pinned to 22.04 and I'm going to update it to 24.04 here and see if I can't fix CI issues that come up. This'll require explicit PRs to update these images in the future, but hopefully that's only once every few ~years so not too much of a burden.
1 parent 67283cc commit 8e24cc6

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/main.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ jobs:
1919
matrix:
2020
include:
2121
- artifact: x86_64-linux
22-
os: ubuntu-latest
22+
os: ubuntu-24.04
2323

2424
- artifact: arm64-linux
25-
os: ubuntu-latest
25+
os: ubuntu-24.04
2626
rust_target: aarch64-unknown-linux-gnu
2727
env:
2828
# Don't build a sysroot for this cross-compiled target since it
@@ -41,15 +41,15 @@ jobs:
4141
-DRUST_TARGET=aarch64-unknown-linux-gnu
4242
4343
- artifact: arm64-macos
44-
os: macos-latest
44+
os: macos-14
4545
rust_target: aarch64-apple-darwin
4646
env:
4747
WASI_SDK_CI_TOOLCHAIN_LLVM_CMAKE_ARGS: >-
4848
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.12
4949
-DCMAKE_OSX_ARCHITECTURES=arm64
5050
5151
- artifact: x86_64-macos
52-
os: macos-latest
52+
os: macos-14
5353
rust_target: x86_64-apple-darwin
5454
env:
5555
WASI_SDK_CI_SKIP_SYSROOT: 1
@@ -58,7 +58,7 @@ jobs:
5858
-DCMAKE_OSX_ARCHITECTURES=x86_64
5959
6060
- artifact: x86_64-windows
61-
os: windows-latest
61+
os: windows-2022
6262

6363
env: ${{ matrix.env || fromJSON('{}') }}
6464
steps:
@@ -165,7 +165,7 @@ jobs:
165165

166166
build-only-sysroot:
167167
name: Build only sysroot
168-
runs-on: ubuntu-22.04
168+
runs-on: ubuntu-24.04
169169
steps:
170170
- uses: actions/checkout@v4
171171
with:
@@ -193,7 +193,7 @@ jobs:
193193
finalize:
194194
name: Finalize wasi-sdk artifacts
195195
needs: build
196-
runs-on: ubuntu-latest
196+
runs-on: ubuntu-24.04
197197
steps:
198198
- uses: actions/checkout@v4
199199
with:
@@ -253,7 +253,7 @@ jobs:
253253
test-standalone:
254254
name: Test standalone toolchain
255255
needs: build
256-
runs-on: ubuntu-latest
256+
runs-on: ubuntu-24.04
257257
steps:
258258
- uses: actions/checkout@v4
259259
with:

0 commit comments

Comments
 (0)