Skip to content

Commit f995dbe

Browse files
authored
Disable tests/benchmarks for libcxx (#476)
These aren't needed anyway and fix a build issue discovered in #474. Additionally a typo was fixed here too.
1 parent 91bca73 commit f995dbe

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cmake/wasi-sdk-sysroot.cmake

+3-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ function(define_wasi_libc_sub target target_suffix lto)
142142
list(JOIN extra_cflags_list " " extra_cflags)
143143

144144
ExternalProject_Add(wasi-libc-${target}${target_suffix}-build
145-
# Currently wasi-libc doesn't support out-of-tree builds so feigh a
145+
# Currently wasi-libc doesn't support out-of-tree builds so feign a
146146
# "download command" which copies the source tree to a different location
147147
# so out-of-tree builds are supported.
148148
DOWNLOAD_COMMAND
@@ -262,6 +262,8 @@ function(define_libcxx_sub target target_suffix extra_target_flags extra_libdir_
262262
-DCMAKE_CXX_FLAGS=${extra_cxxflags}
263263
-DLIBCXX_LIBDIR_SUFFIX=/${target}${extra_libdir_suffix}
264264
-DLIBCXXABI_LIBDIR_SUFFIX=/${target}${extra_libdir_suffix}
265+
-DLIBCXX_INCLUDE_TESTS=OFF
266+
-DLIBCXX_INCLUDE_BENCHMARKS=OFF
265267

266268
# See https://www.scivision.dev/cmake-externalproject-list-arguments/ for
267269
# why this is in `CMAKE_CACHE_ARGS` instead of above

0 commit comments

Comments
 (0)