Open
Description
I refer to vec<T>::make_nt
:
Lines 154 to 158 in 2ce1367
This is implemented using std::strcpy
, which stops copying when it encounters \0
. It seems like more often than not, it's used to hold bytes of a Wasm binary (as a vec<byte_t>
). But Wasm binaries start with \0asm
, so nothing will be copied.
I'm not sure if there are other specializations where stopping at the first \0
makes sense. Considering that we already have vec::make(std::string)
, perhaps vec::make_nt
isn't so helpful and we may want to consider removing it.
#149 is also related.
Metadata
Metadata
Assignees
Labels
No labels