Update spec with latest on-device changes #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanbliu
commented
May 7, 2025
evanbliu
changed the title
|
@padenot - I updated this PR with the rest of the changes we discussed at the Audio WG meeting yesterday. Please take a look when you get a chance :) |
padenot
requested changes
May 19, 2025
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
|
Gentle ping -- @padenot please take a look when you get a chance. Thanks! |
Co-authored-by: Paul Adenot <[email protected]>
|
According to the Web IDL spec, dictionaries can't be attributes, so I removed the options attribute from the SpeechRecognition interface and instead just added a boolean attribute for processLocally. The added benefit of this change is that there can no longer be a state where SpeechRecognition.lang and SpeechRecognition.options.langs have different values. |
padenot
approved these changes
May 26, 2025
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
Co-authored-by: Paul Adenot <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
May 27, 2025
SHA: e8a36c6 Reason: push, by evanbliu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
Closes #156
This PR contains the following changes:
Preview | Diff