[GStreamer] gst_video_frame_map takes non-const pointers before 1.20

spenap · spenap · commit 43c6bef15627 · 2025-03-24T03:03:55.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=290187 Reviewed by Adrian Perez de Castro. gst_video_frame_map was only updated to take immutable GstVideoInfo pointers from GStreamer 1.20 onwards. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::GstMappedFrame::GstMappedFrame): Canonical link: https://commits.webkit.org/292584@main
diff --git a/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp b/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
@@ -722,7 +722,8 @@ Ref<SharedBuffer> GstMappedOwnedBuffer::createSharedBuffer()
 
 GstMappedFrame::GstMappedFrame(GstBuffer* buffer, const GstVideoInfo* info, GstMapFlags flags)
 {
-    gst_video_frame_map(&m_frame, info, buffer, flags);
+    // This cast can be removed once the GStreamer minimum version is raised to 1.20
+    gst_video_frame_map(&m_frame, const_cast<GstVideoInfo*>(info), buffer, flags);
 }
 
 GstMappedFrame::GstMappedFrame(const GRefPtr<GstSample>& sample, GstMapFlags flags)

Original file line number	Diff line number	Diff line change
`@@ -722,7 +722,8 @@ Ref<SharedBuffer> GstMappedOwnedBuffer::createSharedBuffer()`
`722`	`722`
`723`	`723`	`GstMappedFrame::GstMappedFrame(GstBuffer* buffer, const GstVideoInfo* info, GstMapFlags flags)`
`724`	`724`	`{`
`725`		`- gst_video_frame_map(&m_frame, info, buffer, flags);`
	`725`	`+ // This cast can be removed once the GStreamer minimum version is raised to 1.20`
	`726`	`+ gst_video_frame_map(&m_frame, const_cast<GstVideoInfo*>(info), buffer, flags);`
`726`	`727`	`}`
`727`	`728`
`728`	`729`	`GstMappedFrame::GstMappedFrame(const GRefPtr<GstSample>& sample, GstMapFlags flags)`