Skip to content

Commit 64339fe

Browse files
committed
Set Node.js version to 24.x
Also: - Update TunnelService's deprecated process spawning - Add jsdom to ESM transform allowlist to fix tests
1 parent 9f5b4d8 commit 64339fe

8 files changed

Lines changed: 1647 additions & 2093 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ jobs:
1414
strategy:
1515
matrix:
1616
node-version: [
17-
24.22.1
17+
20,
18+
22,
19+
24
1820
]
1921
steps:
2022
- uses: actions/checkout@v2

‎.nvmrc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
24.22.1
1+
lts/krypton

‎Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:24.22.1-bookworm-slim
1+
FROM node:24-bookworm-slim
22

33
EXPOSE 8080 4443
44

‎jest.config.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ module.exports = {
2020
}],
2121
},
2222
transformIgnorePatterns: [
23-
'/node_modules/(?!(@exodus/bytes|@asamuzakjp|@bramus|@csstools|parse5|tough-cookie)/)',
23+
'/node_modules/(?!(' +
24+
'@exodus/bytes|@asamuzakjp|@bramus|@csstools|entities|jsdom|parse5|tough-cookie' +
25+
')/)',
2426
],
2527
setupFilesAfterEnv: [
2628
'<rootDir>/test/common.js',

‎package-lock.json‎

Lines changed: 1631 additions & 2073 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎snap/snapcraft.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ parts:
3232
source: .
3333
after: [ python-deps ]
3434
npm-include-node: true
35-
npm-node-version: 24.22.1
35+
npm-node-version: 24.22.2
3636
build-environment:
3737
- npm_config_unsafe_perm: "true"
3838
- NODE_ENV: "dev"

‎src/tunnel-service.ts‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,13 @@ class TunnelService {
108108
let responseSent = false;
109109
this.tunnelToken = token;
110110
const endpoint = `${token.name}.${token.base}`;
111-
this.pagekiteProcess = spawn(
112-
config.get('ssltunnel.pagekite_cmd'),
113-
[
114-
'--clean',
115-
`--frontend=${endpoint}:${config.get('ssltunnel.port')}`,
116-
`--service_on=https:${endpoint}:localhost:${config.get('ports.https')}:${
117-
this.tunnelToken!.token
118-
}`,
119-
],
120-
{ shell: true }
121-
);
111+
this.pagekiteProcess = spawn(config.get('ssltunnel.pagekite_cmd'), [
112+
'--clean',
113+
`--frontend=${endpoint}:${config.get('ssltunnel.port')}`,
114+
`--service_on=https:${endpoint}:localhost:${config.get('ports.https')}:${
115+
this.tunnelToken!.token
116+
}`,
117+
]);
122118

123119
this.pagekiteProcess.stdout!.on('data', (data) => {
124120
if (DEBUG) {

‎webpack.config.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ const pluginsWeb = [
5959
},
6060
},
6161
}),
62-
new webpack.SourceMapDevToolPlugin({
63-
test: /\.css$/,
64-
filename: '[file].map',
65-
}),
6662
new MiniCssExtractPlugin({
6763
filename: 'bundle/[contenthash]-[name].css',
6864
}),

0 commit comments

Comments
 (0)