Skip to content

Commit b7b43e0

Browse files
digiboridevdigiboridev
authored
feat: media settings ptime warning (#1053)
1 parent bf5b4ee commit b7b43e0

9 files changed

Lines changed: 66 additions & 0 deletions

File tree

‎lib/features/settings/features/media_settings/view/components/encoding_custom_content.dart‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,22 @@ class EncodingCustomContent extends StatelessWidget {
5656
tooltip: context.l10n.settings_encoding_Section_packetization_tooltip,
5757
icon: const Icon(Icons.vertical_split_rounded),
5858
),
59+
Column(
60+
children: [
61+
Text(
62+
context.l10n.settings_encoding_Section_packetization_warning_title,
63+
style: TextStyle(
64+
color: Theme.of(context).colorScheme.error,
65+
fontWeight: FontWeight.bold,
66+
fontSize: 13.0,
67+
),
68+
),
69+
Text(
70+
context.l10n.settings_encoding_Section_packetization_warning_message,
71+
style: TextStyle(color: Theme.of(context).colorScheme.error, fontSize: 12.0),
72+
),
73+
],
74+
),
5975
SlidableSection<int>(
6076
title: context.l10n.settings_encoding_Section_audio_ptime,
6177
optionPrefix: context.l10n.settings_encoding_Section_ptime_prefix,
@@ -92,6 +108,7 @@ class EncodingCustomContent extends StatelessWidget {
92108
}
93109
},
94110
),
111+
95112
const Divider(height: 24),
96113
HeadingSection(
97114
title: context.l10n.settings_encoding_Section_opus_title,

‎lib/l10n/app_localizations.g.dart‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3306,6 +3306,18 @@ abstract class AppLocalizations {
33063306
/// **'Adjust audio packetization-time in milliseconds, can be used to reduce audio latency or fix Network MTU size issues'**
33073307
String get settings_encoding_Section_packetization_tooltip;
33083308

3309+
/// No description provided for @settings_encoding_Section_packetization_warning_title.
3310+
///
3311+
/// In en, this message translates to:
3312+
/// **'Warning:'**
3313+
String get settings_encoding_Section_packetization_warning_title;
3314+
3315+
/// No description provided for @settings_encoding_Section_packetization_warning_message.
3316+
///
3317+
/// In en, this message translates to:
3318+
/// **'Some codecs may struggle with non-default ptime values, causing audible glitches or silence. Use only if you know what you are doing.'**
3319+
String get settings_encoding_Section_packetization_warning_message;
3320+
33093321
/// No description provided for @settings_encoding_Section_preset.
33103322
///
33113323
/// In en, this message translates to:

‎lib/l10n/app_localizations.g.mapper.dart‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/l10n/app_localizations_en.g.dart‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1774,6 +1774,13 @@ class AppLocalizationsEn extends AppLocalizations {
17741774
String get settings_encoding_Section_packetization_tooltip =>
17751775
'Adjust audio packetization-time in milliseconds, can be used to reduce audio latency or fix Network MTU size issues';
17761776

1777+
@override
1778+
String get settings_encoding_Section_packetization_warning_title => 'Warning:';
1779+
1780+
@override
1781+
String get settings_encoding_Section_packetization_warning_message =>
1782+
'Some codecs may struggle with non-default ptime values, causing audible glitches or silence. Use only if you know what you are doing.';
1783+
17771784
@override
17781785
String get settings_encoding_Section_preset => 'Preset';
17791786

‎lib/l10n/app_localizations_it.g.dart‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1789,6 +1789,13 @@ class AppLocalizationsIt extends AppLocalizations {
17891789
String get settings_encoding_Section_packetization_tooltip =>
17901790
'Regola il tempo di pacchettizzazione audio in millisecondi, può essere utilizzato per ridurre la latenza audio o risolvere problemi di dimensione MTU di rete';
17911791

1792+
@override
1793+
String get settings_encoding_Section_packetization_warning_title => 'Attenzione:';
1794+
1795+
@override
1796+
String get settings_encoding_Section_packetization_warning_message =>
1797+
'Alcuni codec potrebbero avere difficoltà con valori ptime non predefiniti, causando glitch audio udibili o silenzio. Usare solo se si sa cosa si sta facendo.';
1798+
17921799
@override
17931800
String get settings_encoding_Section_preset => 'Preimpostato';
17941801

‎lib/l10n/app_localizations_uk.g.dart‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1788,6 +1788,13 @@ class AppLocalizationsUk extends AppLocalizations {
17881788
String get settings_encoding_Section_packetization_tooltip =>
17891789
'Налаштування часу пакетування аудіо в мілісекундах, можна використовувати для зменшення затримки аудіо або вирішення проблем із розміром MTU мережі';
17901790

1791+
@override
1792+
String get settings_encoding_Section_packetization_warning_title => 'Увага:';
1793+
1794+
@override
1795+
String get settings_encoding_Section_packetization_warning_message =>
1796+
'Деякі кодеки можуть погано працювати з нестандартними значеннями ptime, що спричиняє чутні збої або тишу. Використовуйте лише якщо розумієте, що робите.';
1797+
17911798
@override
17921799
String get settings_encoding_Section_preset => 'Налаштування';
17931800

‎lib/l10n/arb/app_en.arb‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,6 +1436,10 @@
14361436
"@settings_encoding_Section_packetization_title": {},
14371437
"settings_encoding_Section_packetization_tooltip": "Adjust audio packetization-time in milliseconds, can be used to reduce audio latency or fix Network MTU size issues",
14381438
"@settings_encoding_Section_packetization_tooltip": {},
1439+
"settings_encoding_Section_packetization_warning_title": "Warning:",
1440+
"@settings_encoding_Section_packetization_warning_title": {},
1441+
"settings_encoding_Section_packetization_warning_message": "Some codecs may struggle with non-default ptime values, causing audible glitches or silence. Use only if you know what you are doing.",
1442+
"@settings_encoding_Section_packetization_warning_message": {},
14391443
"settings_encoding_Section_preset": "Preset",
14401444
"@settings_encoding_Section_preset": {},
14411445
"settings_encoding_Section_preset_balance": "Balanced",

‎lib/l10n/arb/app_it.arb‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,6 +1436,10 @@
14361436
"@settings_encoding_Section_packetization_title": {},
14371437
"settings_encoding_Section_packetization_tooltip": "Regola il tempo di pacchettizzazione audio in millisecondi, può essere utilizzato per ridurre la latenza audio o risolvere problemi di dimensione MTU di rete",
14381438
"@settings_encoding_Section_packetization_tooltip": {},
1439+
"settings_encoding_Section_packetization_warning_title": "Attenzione:",
1440+
"@settings_encoding_Section_packetization_warning_title": {},
1441+
"settings_encoding_Section_packetization_warning_message": "Alcuni codec potrebbero avere difficoltà con valori ptime non predefiniti, causando glitch audio udibili o silenzio. Usare solo se si sa cosa si sta facendo.",
1442+
"@settings_encoding_Section_packetization_warning_message": {},
14391443
"settings_encoding_Section_preset": "Preimpostato",
14401444
"@settings_encoding_Section_preset": {},
14411445
"settings_encoding_Section_preset_balance": "Bilanciato",

‎lib/l10n/arb/app_uk.arb‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1436,6 +1436,10 @@
14361436
"@settings_encoding_Section_packetization_title": {},
14371437
"settings_encoding_Section_packetization_tooltip": "Налаштування часу пакетування аудіо в мілісекундах, можна використовувати для зменшення затримки аудіо або вирішення проблем із розміром MTU мережі",
14381438
"@settings_encoding_Section_packetization_tooltip": {},
1439+
"settings_encoding_Section_packetization_warning_title": "Увага:",
1440+
"@settings_encoding_Section_packetization_warning_title": {},
1441+
"settings_encoding_Section_packetization_warning_message": "Деякі кодеки можуть погано працювати з нестандартними значеннями ptime, що спричиняє чутні збої або тишу. Використовуйте лише якщо розумієте, що робите.",
1442+
"@settings_encoding_Section_packetization_warning_message": {},
14391443
"settings_encoding_Section_preset": "Налаштування",
14401444
"@settings_encoding_Section_preset": {},
14411445
"settings_encoding_Section_preset_balance": "Збалансований",

0 commit comments

Comments
 (0)