refactor: migrate FeatureAccess from *Feature to *Config with mappers (#882)

Author: SERDUN

lib/app/router/app_router.dart

@@ -11,6 +11,7 @@ import 'package:webtrit_phone/blocs/app/app_bloc.dart';
 import 'package:webtrit_phone/data/data.dart';
 import 'package:webtrit_phone/features/features.dart';
 import 'package:webtrit_phone/models/models.dart';
+import 'package:webtrit_phone/resolvers/resolvers.dart';
 
 import 'deeplinks.dart';
 
@@ -29,14 +30,16 @@ class AppRouter extends RootStackRouter {
     this._launchEmbeddedData,
     this._bottomMenuFeature,
     this._featureChecker,
+    this._initialTabResolver,
   );
 
   final AppBloc _appBloc;
   final AppPermissions _appPermissions;
   final FeatureChecker _featureChecker;
+  final InitialTabResolver _initialTabResolver;
 
   final EmbeddedData? _launchEmbeddedData;
-  final BottomMenuFeature _bottomMenuFeature;
+  final BottomMenuConfig _bottomMenuFeature;
 
   Session get session => _appBloc.state.session;
 
@@ -58,7 +61,7 @@ class AppRouter extends RootStackRouter {
   /// Retrieves the initial tab  for the main screen.
   ///
   /// This getter determines the initial tab to display on the main screen
-  BottomMenuTab get _mainInitialTab => _bottomMenuFeature.activeTab;
+  BottomMenuTab get _mainInitialTab => _initialTabResolver.resolve();
 
   @override
   List<AutoRoute> get routes => [

lib/app/router/main_shell.dart

@@ -172,7 +172,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
         ),
         RepositoryProvider<VoicemailRepository>(
           create: (context) {
-            final isVoicemailsEnabled = featureAccess.settingsFeature.isVoicemailsEnabled;
+            final isVoicemailsEnabled = featureAccess.settingsConfig.isVoicemailsEnabled;
 
             if (isVoicemailsEnabled) {
               return VoicemailRepositoryImpl(
@@ -266,7 +266,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
               dispose: (context, service) => service.dispose(),
               lazy: false,
             ),
-            if (featureAccess.bottomMenuFeature.getTabEnabled<RecentsBottomMenuTab>()?.useCdrs == true)
+            if (featureAccess.bottomMenuConfig.getTabEnabled<RecentsBottomMenuTab>()?.useCdrs == true)
               Provider<CdrsSyncWorker>(
                 create: (context) =>
                     CdrsSyncWorker(context.read<CdrsLocalRepository>(), context.read<CdrsRemoteRepository>())..init(),
@@ -329,7 +329,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
                       final appPermissions = context.read<AppPermissions>();
 
                       Future<bool> isFutureEnabled() async {
-                        final contactTab = featureAccess.bottomMenuFeature.getTabEnabled<ContactsBottomMenuTab>();
+                        final contactTab = featureAccess.bottomMenuConfig.getTabEnabled<ContactsBottomMenuTab>();
                         final contactSourceTypes = contactTab?.contactSourceTypes ?? [];
                         return contactSourceTypes.contains(ContactSourceType.local);
                       }
@@ -375,8 +375,8 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
                       final encodingSettingsRepository = context.read<EncodingSettingsRepository>();
                       final diagnosticService = context.read<DiagnosticService>();
 
-                      final encodingConfig = featureAccess.callFeature.encoding;
-                      final peerConnectionConfig = featureAccess.callFeature.peerConnection;
+                      final encodingConfig = featureAccess.callConfig.encoding;
+                      final peerConnectionConfig = featureAccess.callConfig.peerConnection;
 
                       // Initialize media builder with app-configured audio/video constraints
                       // Used to capture synchronized MediaStream (audio+video) for WebRTC track addition.
@@ -438,7 +438,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
                         ),
                         iceFilter: FilterWithAppSettings(iceSettingsRepository),
                         peerConnectionPolicyApplier: pearConnectionPolicyApplier,
-                        sipPresenceEnabled: featureAccess.sipPresenceFeature.sipPresenceSupport,
+                        sipPresenceEnabled: featureAccess.sipPresenceConfig.sipPresenceSupport,
                         onCallEnded: () => cdrsSyncWorker?.forceSync(const Duration(seconds: 1)),
                         onDiagnosticReportRequested: (id, error) => diagnosticService.request(
                           DiagnosticType.androidCallkeepOnly,
@@ -456,7 +456,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
                       return MessagingBloc(
                         session.userId,
                         createMessagingSocket(session.coreUrl!, session.token!, session.tenantId),
-                        featureAccess.messagingFeature,
+                        featureAccess.messagingConfig,
                         context.read<ChatsRepository>(),
                         context.read<ChatsOutboxRepository>(),
                         context.read<SmsRepository>(),
@@ -526,7 +526,7 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
                       ],
                       child: Builder(
                         builder: (context) {
-                          final sipPresenceFeature = featureAccess.sipPresenceFeature;
+                          final sipPresenceFeature = featureAccess.sipPresenceConfig;
 
                           return PresenceViewParams(
                             viewSource: switch (sipPresenceFeature.sipPresenceSupport) {
@@ -568,12 +568,12 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
   /// - [UserRepository]: polled every 10 seconds to keep user data up to date.
   /// - [SystemInfoRepository]: polled every 5 minutes to refresh system information.
   /// - [VoicemailRepository]: polled every 5 minutes, but only if the voicemail feature is enabled
-  ///   in [FeatureAccess.settingsFeature].
+  ///   in [FeatureAccess.settingsConfig].
   ///
   /// This method centralizes the polling configuration, so changes in polling logic or intervals
   /// can be made here without touching the [Provider] or [PollingService] setup.
   List<PollingRegistration> _pollingRegistrations(BuildContext context) {
-    final isVoicemailsEnabled = context.read<FeatureAccess>().settingsFeature.isVoicemailsEnabled;
+    final isVoicemailsEnabled = context.read<FeatureAccess>().settingsConfig.isVoicemailsEnabled;
 
     return [
       PollingRegistration(
@@ -604,12 +604,12 @@ class _MainShellState extends State<MainShell> with WidgetsBindingObserver {
   ///
   /// Current registrations:
   /// - [VoicemailRepository]: refreshed when going online, but only if the voicemail feature
-  ///   is enabled in [FeatureAccess.settingsFeature].
+  ///   is enabled in [FeatureAccess.settingsConfig].
   ///
   /// This method centralizes the connectivity recovery configuration, so changes in
   /// registration logic can be made here without touching the [Provider] or service setup.
   List<ConnectivityRecoveryRegistration> _connectivityRecoveryRegistrations(BuildContext context) {
-    final isVoicemailsEnabled = context.read<FeatureAccess>().settingsFeature.isVoicemailsEnabled;
+    final isVoicemailsEnabled = context.read<FeatureAccess>().settingsConfig.isVoicemailsEnabled;
 
     return [if (isVoicemailsEnabled) ConnectivityRecoveryRegistration.refreshable(context.read<VoicemailRepository>())];
   }

lib/app/view/app.dart

@@ -13,6 +13,7 @@ import 'package:webtrit_phone/features/features.dart';
 import 'package:webtrit_phone/l10n/l10n.dart';
 import 'package:webtrit_phone/repositories/repositories.dart';
 import 'package:webtrit_phone/theme/theme.dart';
+import 'package:webtrit_phone/resolvers/resolvers.dart';
 
 class App extends StatefulWidget {
   const App({super.key});
@@ -39,12 +40,19 @@ class _AppState extends State<App> {
       sessionRepository: context.read<SessionRepository>(),
       appInfo: context.read<AppInfo>(),
     );
+
+    final initialTabResolver = BottomMenuInitialTabResolver(
+      config: featureAccess.bottomMenuConfig,
+      repository: context.read<ActiveMainFlavorRepository>(),
+    );
+
     appRouter = AppRouter(
       appBloc,
       context.read<AppPermissions>(),
-      featureAccess.loginFeature.launchLoginPage,
-      featureAccess.bottomMenuFeature,
+      featureAccess.loginConfig.launchLoginPage,
+      featureAccess.bottomMenuConfig,
       featureAccess.toChecker(),
+      initialTabResolver,
     );
   }
 

lib/bootstrap.dart

@@ -177,7 +177,7 @@ Future<void> _initCallkeep(FeatureAccess featureAccess) async {
   AndroidCallkeepServices.backgroundPushNotificationBootstrapService.initializeCallback(onPushNotificationSyncCallback);
 
   // If the fallback incoming call trigger via SMS is enabled in the feature access config
-  if (featureAccess.callFeature.callTriggerConfig.smsFallback.enabled) {
+  if (featureAccess.callConfig.triggerConfig.smsFallback.enabled) {
     // Configure Android CallKeep to process incoming SMS messages
     // - prefix: filters SMS messages by required prefix
     // - regexPattern: extracts callId, handle, displayName, and hasVideo from the SMS body

lib/data/app_metadata_provider.dart

@@ -54,7 +54,7 @@ class DefaultAppMetadataProvider implements AppMetadataProvider {
     final token = _secureStorage.readToken();
     final coreUrl = _secureStorage.readCoreUrl();
     final tenantId = _secureStorage.readTenantId();
-    final urls = _featureAccess?.embeddedFeature.embeddedResources.map((e) => e.uri.toString()).toList();
+    final urls = _featureAccess?.embeddedConfig.embeddedResources.map((e) => e.uri.toString()).toList();
 
     return <String, String>{
       'app': _packageInfo.appName,