Improve admin notices clarity and fix term list output handling

Author: ajaydsouza

includes/admin/class-admin-notices.php

@@ -164,9 +164,9 @@ private function register_fulltext_index_notice() {
 				'id'          => 'bsearch_missing_fulltext_index',
 				'message'     => sprintf(
 					'<p>%s <a href="%s">%s</a></p>',
-					esc_html__( 'Better Search: Some fulltext indexes are missing, which will affect search results.', 'better-search' ),
+					esc_html__( 'Better Search: Some FULLTEXT indexes are missing from your database, which will prevent search results from being found. Please run the recreate indexes tool from the Tools page to restore search functionality.', 'better-search' ),
 					esc_url( admin_url( 'admin.php?page=bsearch_tools_page#bsearch-recreate-index' ) ),
-					esc_html__( 'Click here to recreate indexes.', 'better-search' )
+					esc_html__( 'Go to Tools page', 'better-search' )
 				),
 				'type'        => 'warning',
 				'dismissible' => true,
@@ -203,9 +203,9 @@ private function register_missing_table_notice() {
 				'id'          => 'bsearch_missing_tables',
 				'message'     => sprintf(
 					'<p>%s <a href="%s">%s</a></p>',
-					esc_html__( 'Better Search: Some tables are missing, which will affect search results.', 'better-search' ),
+					esc_html__( 'Better Search: Some tables are missing, which will affect search results performance. Visit the Tools page to manually recreate the tables.', 'better-search' ),
 					esc_url( admin_url( 'admin.php?page=bsearch_tools_page#bsearch-recreate-tables' ) ),
-					esc_html__( 'Click here to recreate tables.', 'better-search' )
+					esc_html__( 'Go to Tools page', 'better-search' )
 				),
 				'type'        => 'warning',
 				'dismissible' => true,

includes/admin/class-settings-wizard.php

@@ -413,9 +413,9 @@ protected function render_custom_tables_interface() {
 		}
 
 		$table_manager = $custom_tables->admin->table_manager;
+		$percentage    = $table_manager->get_indexing_percentage();
 		$content_count = $table_manager->get_content_count();
 		$post_count    = $table_manager->get_post_count();
-		$percentage    = $post_count > 0 ? min( 100, round( ( $content_count / $post_count ) * 100 ) ) : 0;
 
 		// Check if indexing is in progress.
 		$reindex_state = $custom_tables->admin->get_reindex_state();

includes/general-template.php

@@ -855,7 +855,7 @@ function get_bsearch_term_list( $post = 0, $args = array() ) {
 	}
 	$output = array_filter( $output );
 
-	$output = $args['before'] . implode( $args['sep'], $output ) . $args['after'];
+	$output = $args['before'] . implode( $args['sep'], array_map( 'strval', $output ) ) . $args['after'];
 
 	/**
 	 * Filters the post terms for the current post.