PHPCompatibility check

Author: ajaydsouza

composer.json

@@ -30,7 +30,8 @@
         "php-stubs/wordpress-stubs": "^6",
         "wp-coding-standards/wpcs": "^3",
         "dealerdirect/phpcodesniffer-composer-installer": "^1",
-        "phpcompatibility/phpcompatibility-wp": "^2",
+        "phpcompatibility/phpcompatibility-wp": "*",
+        "phpcompatibility/php-compatibility": "dev-develop as 9.99.99",
         "yoast/phpunit-polyfills": "^3",
         "phpunit/phpunit": "^9 || ^10 || ^11 || ^12"
     },
@@ -40,11 +41,13 @@
             "dealerdirect/phpcodesniffer-composer-installer": true
         }
     },
+    "minimum-stability": "dev",
+    "prefer-stable": true,
     "scripts": {
         "phpstan": "vendor/bin/phpstan analyse --memory-limit=2048M",
         "phpstan-baseline": "vendor/bin/phpstan analyse --memory-limit=2048M --generate-baseline",
         "phpcs": "vendor/bin/phpcs -p -v -s --standard=phpcs.xml.dist $(find . -name '*.php')",
         "phpcbf": "vendor/bin/phpcbf -p -v -s --standard=phpcs.xml.dist $(find . -name '*.php')",
-        "zip": "mkdir -p build && zip -X -r build/contextual-related-posts.zip . -x '*.git*' 'node_modules/*' '.*' '*/.git*' '*/.DS_Store' 'CODE_OF_CONDUCT.md' 'CONTRIBUTING.md' 'ISSUE_TEMPLATE.md' 'PULL_REQUEST_TEMPLATE.md' '*.dist' '*.yml' '*.neon' 'composer.*' 'package.json' 'dev-helpers**' 'build**' 'wporg-assets**' 'phpunit**'"
+        "zip": "mkdir -p build && zip -X -r build/$(basename $(pwd)).zip . -x '*.git*' 'node_modules/*' '.*' '*/.git*' '*/.DS_Store' 'CODE_OF_CONDUCT.md' 'CONTRIBUTING.md' 'ISSUE_TEMPLATE.md' 'PULL_REQUEST_TEMPLATE.md' '*.dist' '*.yml' '*.neon' 'composer.*' 'package.json' 'dev-helpers**' 'build**' 'wporg-assets**'"
     }
-}
+}

includes/admin/class-settings.php

@@ -24,7 +24,6 @@
  */
 class Settings {
 
-
 	/**
 	 * Settings API instance.
 	 *
@@ -697,7 +696,7 @@ public static function settings_list() {
 				'id'      => 'cornerstone_post_ids',
 				'name'    => esc_html__( 'Cornerstone IDs', 'contextual-related-posts' ),
 				'desc'    => sprintf(
-							/* translators: 1: Opening anchor tag, 2: Closing anchor tag */
+					/* translators: 1: Opening anchor tag, 2: Closing anchor tag */
 					esc_html__( 'Comma-separated list of post/page or custom post type IDs to be used as cornerstone posts. Posts with these IDs will be randomly selected and then included in the list of related posts. Roughly 20%% of the related posts will be chosen from this list. Learn more about %1$sCornerstone Posts%2$s.', 'contextual-related-posts' ),
 					'<a href="https://webberzone.com/support/knowledgebase/cornerstone-posts-in-contextual-related-posts/" target="_blank">',
 					'</a>'
@@ -1078,7 +1077,7 @@ public static function settings_feed() {
 	 */
 	public static function settings_performance() {
 		$custom_tables_desc = sprintf(
-		/* translators: 1: Opening a tag, 2: Closing a tag */
+			/* translators: 1: Opening a tag, 2: Closing a tag */
 			esc_html__( 'Efficient Content Storage and Indexing (ECSI) creates a dedicated database table optimized for related content queries. This enhances performance, particularly on sites with a large number of posts or high traffic. To create the ECSI tables, visit the %1$sTools tab%2$s.', 'contextual-related-posts' ),
 			'<a href="' . esc_url( admin_url( 'tools.php?page=crp_tools_page' ) ) . '" target="_blank">',
 			'</a>'
@@ -1174,7 +1173,7 @@ public static function settings_performance() {
 	/**
 	 * Get the various styles.
 	 *
-	 * @since  3.5.0
+	 * @since 3.5.0
 	 * @return array Associative array of styles.
 	 */
 	public static function get_styles() {
@@ -1225,7 +1224,7 @@ public static function get_styles() {
 	/**
 	 * Get the various order settings.
 	 *
-	 * @since  3.5.0
+	 * @since 3.5.0
 	 * @return array Order settings.
 	 */
 	public static function get_orderings() {
@@ -1251,7 +1250,7 @@ public static function get_orderings() {
 	 *
 	 * @since 3.5.0
 	 *
-	 * @param  array $links Array of links.
+	 * @param array $links Array of links.
 	 * @return array
 	 */
 	public function plugin_actions_links( $links ) {
@@ -1269,8 +1268,8 @@ public function plugin_actions_links( $links ) {
 	 *
 	 * @since 3.5.0
 	 *
-	 * @param  array  $links Array of Links.
-	 * @param  string $file  Current file.
+	 * @param array  $links Array of Links.
+	 * @param string $file Current file.
 	 * @return array
 	 */
 	public function plugin_row_meta( $links, $file ) {
@@ -1294,14 +1293,14 @@ public function plugin_row_meta( $links, $file ) {
 	 */
 	public function get_help_sidebar() {
 		$help_sidebar =
-		/* translators: 1: Plugin support site link. */
-		'<p>' . sprintf( __( 'For more information or how to get support visit the <a href="%s" target="_blank">support site</a>.', 'contextual-related-posts' ), esc_url( 'https://webberzone.com/support/' ) ) . '</p>' .
-		'<p>' . sprintf(
-		/* translators: 1: Github issues link, 2: Github plugin page link. */
-			__( '<a href="%1$s" target="_blank">Post an issue</a> on <a href="%2$s" target="_blank">GitHub</a> (bug reports only).', 'contextual-related-posts' ),
-			esc_url( 'https://github.com/WebberZone/contextual-related-posts/issues' ),
-			esc_url( 'https://github.com/WebberZone/contextual-related-posts' )
-		) . '</p>';
+			/* translators: 1: Plugin support site link. */
+			'<p>' . sprintf( __( 'For more information or how to get support visit the <a href="%s" target="_blank">support site</a>.', 'contextual-related-posts' ), esc_url( 'https://webberzone.com/support/' ) ) . '</p>' .
+			'<p>' . sprintf(
+				/* translators: 1: Github issues link, 2: Github plugin page link. */
+				__( '<a href="%1$s" target="_blank">Post an issue</a> on <a href="%2$s" target="_blank">GitHub</a> (bug reports only).', 'contextual-related-posts' ),
+				esc_url( 'https://github.com/WebberZone/contextual-related-posts/issues' ),
+				esc_url( 'https://github.com/WebberZone/contextual-related-posts' )
+			) . '</p>';
 
 		/**
 		 * Filter to modify the help sidebar content.
@@ -1336,12 +1335,12 @@ public function get_help_tabs() {
 				'title'   => __( 'Tools', 'contextual-related-posts' ),
 				'content' =>
 				'<p>' . __( 'This screen provides some tools that help maintain certain features of Contextual Related Posts.', 'contextual-related-posts' ) . '</p>' .
-							'<p>' . __( 'Clear the cache, recreate the fulltext indices (including code to manually run this in phpMyAdmin), export/import settings and delete the older settings.', 'contextual-related-posts' ) . '</p>' .
-							'<p>' . sprintf(
-							/* translators: 1: Link to Knowledge Base article. */
-								__( 'You can find more information on each of these tools in this <a href="%1$s" target="_blank">knowledgebase article</a>.', 'contextual-related-posts' ),
-								esc_url( 'https://webberzone.com/support/knowledgebase/contextual-related-posts-settings-tools/' )
-							) . '</p>',
+					'<p>' . __( 'Clear the cache, recreate the fulltext indices (including code to manually run this in phpMyAdmin), export/import settings and delete the older settings.', 'contextual-related-posts' ) . '</p>' .
+					'<p>' . sprintf(
+					/* translators: 1: Link to Knowledge Base article. */
+						__( 'You can find more information on each of these tools in this <a href="%1$s" target="_blank">knowledgebase article</a>.', 'contextual-related-posts' ),
+						esc_url( 'https://webberzone.com/support/knowledgebase/contextual-related-posts-settings-tools/' )
+					) . '</p>',
 			),
 		);
 
@@ -1362,7 +1361,7 @@ public function get_help_tabs() {
 	 */
 	public static function get_admin_footer_text() {
 		return sprintf(
-		/* translators: 1: Opening achor tag with Plugin page link, 2: Closing anchor tag, 3: Opening anchor tag with review link. */
+			/* translators: 1: Opening achor tag with Plugin page link, 2: Closing anchor tag, 3: Opening anchor tag with review link. */
 			__( 'Thank you for using %1$sContextual Related Posts by WebberZone%2$s! Please %3$srate us%2$s on %3$sWordPress.org%2$s', 'contextual-related-posts' ),
 			'<a href="https://webberzone.com/plugins/contextual-related-posts/" target="_blank">',
 			'</a>',
@@ -1535,15 +1534,13 @@ public static function tags_search() {
 		}
 		$s = trim( $s );
 
-		/**
-	* This filter has been defined in /wp-admin/includes/ajax-actions.php
-*/
+		/** This filter has been defined in /wp-admin/includes/ajax-actions.php */
 		$term_search_min_chars = (int) apply_filters( 'term_search_min_chars', 2, $tax, $s );
 
 		/*
-		* Require $term_search_min_chars chars for matching (default: 2)
-		* ensure it's a non-negative, non-zero integer.
-		*/
+		 * Require $term_search_min_chars chars for matching (default: 2)
+		 * ensure it's a non-negative, non-zero integer.
+		 */
 		if ( ( 0 === $term_search_min_chars ) || ( strlen( $s ) < $term_search_min_chars ) ) {
 			wp_die();
 		}
@@ -1575,13 +1572,13 @@ public static function settings_page_header() {
 		?>
 		<p>
 			<a class="crp_button crp_button_green" href="<?php echo esc_url( admin_url( 'tools.php?page=crp_tools_page' ) ); ?>">
-		<?php esc_html_e( 'Visit the Tools page', 'contextual-related-posts' ); ?>
+				<?php esc_html_e( 'Visit the Tools page', 'contextual-related-posts' ); ?>
 			</a>
-		<?php if ( ! $crp_freemius->is_paying() ) { ?>
+			<?php if ( ! $crp_freemius->is_paying() ) { ?>
 			<a class="crp_button crp_button_gold" href="<?php echo esc_url( $crp_freemius->get_upgrade_url() ); ?>">
-			<?php esc_html_e( 'Upgrade to Pro', 'contextual-related-posts' ); ?>
+				<?php esc_html_e( 'Upgrade to Pro', 'contextual-related-posts' ); ?>
 			</a>
-		<?php } ?>
+			<?php } ?>
 		</p>
 
 		<?php
@@ -1590,8 +1587,8 @@ public static function settings_page_header() {
 	/**
 	 * Updated the settings fields to display a pro version link.
 	 *
-	 * @param  string $output Settings field HTML.
-	 * @param  array  $args   Settings field arguments.
+	 * @param string $output Settings field HTML.
+	 * @param array  $args   Settings field arguments.
 	 * @return string Updated HTML.
 	 */
 	public static function after_setting_output( $output, $args ) {

includes/admin/settings/class-metabox-api.php

@@ -353,7 +353,7 @@ public function sanitize_post_meta( $settings ) {
 				$ids   = array();
 				$names = array();
 
-				$taxes = array_unique( str_getcsv( $settings[ $key ] ) );
+				$taxes = array_unique( str_getcsv( $settings[ $key ], ',', '"', '\\' ) );
 
 				foreach ( $taxes as $tax ) {
 					$tax_name = get_term_by( 'name', $tax, $fields['tax'] );

includes/admin/settings/class-settings-api.php

@@ -416,8 +416,6 @@ public function add_custom_menu_page( $menu ) {
 	 * Add admin menu.
 	 */
 	public function admin_menu() {
-		global ${$this->prefix . '_menu_pages'};
-
 		foreach ( $this->menus as $menu ) {
 			$menu_page = $this->add_custom_menu_page( $menu );
 
@@ -426,7 +424,6 @@ public function admin_menu() {
 				$this->settings_page = $menu_page;
 			}
 		}
-		${$this->prefix . '_menu_pages'} = $this->menu_pages;
 
 		// Load the settings contextual help.
 		add_action( 'load-' . $this->settings_page, array( $this, 'settings_help' ) );

includes/admin/settings/class-settings-sanitize.php

@@ -262,7 +262,7 @@ public static function str_putcsv( $input_array, $delimiter = ',', $enclosure =
 	 */
 	public static function sanitize_tax_slugs( &$settings, $source_key, $target_key ) {
 		if ( isset( $settings[ $source_key ] ) ) {
-			$slugs = array_unique( str_getcsv( $settings[ $source_key ] ) );
+			$slugs = array_unique( str_getcsv( $settings[ $source_key ], ',', '"', '\\' ) );
 
 			foreach ( $slugs as $slug ) {
 				// Pattern is Name (taxonomy:term_taxonomy_id).

phpcs.xml.dist

@@ -38,4 +38,8 @@
 	<rule ref="Generic.Commenting.Todo"/>
 	<rule ref="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed"/>
 
+	<!-- Check for PHP 7.4+ compatibility. -->
+	<config name="testVersion" value="7.4-"/>
+	<rule ref="PHPCompatibilityWP"/>
+
 </ruleset>